| Message ID | 20230809071812.547229-2-harshit.m.mogalapalli@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next,v2,1/2] mmc: sunplus: Fix error handling in spmmc_drv_probe() | expand |
On Wed, 9 Aug 2023 at 09:19, Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> wrote: > > The platform_get_irq() function returns negative error codes on failure. > > Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Applied for fixes and by adding a stable tag, thanks! Kind regards Uffe > --- > v1->v2: Split into two patches as they are doing different things. > > This is based on static analysis with smatch, only compile tested. > --- > drivers/mmc/host/sunplus-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c > index 2bdebeb1f8e4..e9cb1a57cb75 100644 > --- a/drivers/mmc/host/sunplus-mmc.c > +++ b/drivers/mmc/host/sunplus-mmc.c > @@ -885,7 +885,7 @@ static int spmmc_drv_probe(struct platform_device *pdev) > return dev_err_probe(&pdev->dev, PTR_ERR(host->rstc), "rst get fail\n"); > > host->irq = platform_get_irq(pdev, 0); > - if (host->irq <= 0) > + if (host->irq < 0) > return host->irq; > > ret = devm_request_threaded_irq(&pdev->dev, host->irq, > -- > 2.39.3 >
On Wed, Aug 09, 2023 at 01:33:51PM +0200, Ulf Hansson wrote: > On Wed, 9 Aug 2023 at 09:19, Harshit Mogalapalli > <harshit.m.mogalapalli@oracle.com> wrote: > > > > The platform_get_irq() function returns negative error codes on failure. > > > > Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > > Applied for fixes and by adding a stable tag, thanks! It's not really a fix. The platform_get_irq() function can't actually return zero. I asked Arnd about this and he said that there were some arches where zero was a valid IRQ but they're not in the upstream kernel any more and we're hopefully not going to do that again. regards, dan carpenter
On Wed, 9 Aug 2023 at 13:51, Dan Carpenter <dan.carpenter@linaro.org> wrote: > > On Wed, Aug 09, 2023 at 01:33:51PM +0200, Ulf Hansson wrote: > > On Wed, 9 Aug 2023 at 09:19, Harshit Mogalapalli > > <harshit.m.mogalapalli@oracle.com> wrote: > > > > > > The platform_get_irq() function returns negative error codes on failure. > > > > > > Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") > > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > > > Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ > > > Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> > > > > Applied for fixes and by adding a stable tag, thanks! > > It's not really a fix. The platform_get_irq() function can't actually > return zero. > > I asked Arnd about this and he said that there were some arches where > zero was a valid IRQ but they're not in the upstream kernel any more and > we're hopefully not going to do that again. Alright, I moved this to the next branch and dropped the fixes and stable tags. Kind regards Uffe
diff --git a/drivers/mmc/host/sunplus-mmc.c b/drivers/mmc/host/sunplus-mmc.c index 2bdebeb1f8e4..e9cb1a57cb75 100644 --- a/drivers/mmc/host/sunplus-mmc.c +++ b/drivers/mmc/host/sunplus-mmc.c @@ -885,7 +885,7 @@ static int spmmc_drv_probe(struct platform_device *pdev) return dev_err_probe(&pdev->dev, PTR_ERR(host->rstc), "rst get fail\n"); host->irq = platform_get_irq(pdev, 0); - if (host->irq <= 0) + if (host->irq < 0) return host->irq; ret = devm_request_threaded_irq(&pdev->dev, host->irq,
The platform_get_irq() function returns negative error codes on failure. Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/all/a3829ed3-d827-4b9d-827e-9cc24a3ec3bc@moroto.mountain/ Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> --- v1->v2: Split into two patches as they are doing different things. This is based on static analysis with smatch, only compile tested. --- drivers/mmc/host/sunplus-mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)