| Message ID | 20231019195752.62692-1-edson.drosdeck@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: block: Use octal for file permissions | expand |
On Thu, 19 Oct 2023 at 21:58, Edson Juliano Drosdeck <edson.drosdeck@gmail.com> wrote: > > Octal permissions are preferred as stated in > Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions > with octal permissions when creating the files. > > Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com> Thanks for your patch! Replacing symbolic permissions with octal permissions makes sense to me. However, I don't want one patch per line that needs to be changed. Instead, please go over all the files in drivers/mmc/core and fix all of them in one patch. Another patch can be done for drivers/mmc/hosts/* Kind regards Uffe > --- > drivers/mmc/core/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c > index b5b414a71e0b..edb653d8fbfa 100644 > --- a/drivers/mmc/core/block.c > +++ b/drivers/mmc/core/block.c > @@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md) > > if (mmc_card_mmc(card)) { > md->ext_csd_dentry = > - debugfs_create_file("ext_csd", S_IRUSR, root, card, > + debugfs_create_file("ext_csd", 0400, root, card, > &mmc_dbg_ext_csd_fops); > } > } > -- > 2.39.2 >
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index b5b414a71e0b..edb653d8fbfa 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md) if (mmc_card_mmc(card)) { md->ext_csd_dentry = - debugfs_create_file("ext_csd", S_IRUSR, root, card, + debugfs_create_file("ext_csd", 0400, root, card, &mmc_dbg_ext_csd_fops); } }
Octal permissions are preferred as stated in Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions with octal permissions when creating the files. Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com> --- drivers/mmc/core/block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)