| Message ID | 20240205191310.1848561-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: wbsd: remove redundant assignment to variable id | expand |
On Mon, 5 Feb 2024 at 20:13, Colin Ian King <colin.i.king@gmail.com> wrote: > > The variable id is being initialized with a value that is never > read, it is being re-assigned later on. The initialization is > redundant and can be removed. > > Cleans up clang scan build warning: > drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id' > is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/mmc/host/wbsd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c > index 001a468bc149..f0562f712d98 100644 > --- a/drivers/mmc/host/wbsd.c > +++ b/drivers/mmc/host/wbsd.c > @@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host) > continue; > > for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) { > - id = 0xFFFF; > - > host->config = config_ports[i]; > host->unlock_code = unlock_codes[j]; A few lines down there is check "if (id != 0xFFFF)". Looks like that is a redundant check. Would you mind cleaning up that part too, as a part of the $subject patch? Kind regards Uffe
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index 001a468bc149..f0562f712d98 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host) continue; for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) { - id = 0xFFFF; - host->config = config_ports[i]; host->unlock_code = unlock_codes[j];
The variable id is being initialized with a value that is never read, it is being re-assigned later on. The initialization is redundant and can be removed. Cleans up clang scan build warning: drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/mmc/host/wbsd.c | 2 -- 1 file changed, 2 deletions(-)