| Message ID | 20240215-mmc-fix-davinci-v1-1-a593678ca7bf@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: davinci_mmc: Drop dangling variable | expand |
On Thu, 15 Feb 2024 at 14:28, Linus Walleij <linus.walleij@linaro.org> wrote: > > The sg_miter conversion left a dangling unused variable. > Drop it. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202402142042.vg0lnLdb-lkp@intel.com/ > Fixes: ed01d210fd91 ("mmc: davinci_mmc: Use sg_miter for PIO") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/mmc/host/davinci_mmc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index c46577305138..8bd938919687 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -211,7 +211,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, > unsigned int n) > { > struct sg_mapping_iter *sgm = &host->sg_miter; > - size_t sglen; > u8 *p; > unsigned int i; > > @@ -224,7 +223,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, > return; > } > p = sgm->addr; > - sglen = sgm->length; > > /* NOTE: we never transfer more than rw_threshold bytes > * to/from the fifo here; there's no I/O overlap. > > --- > base-commit: 26d7d52b6253574d5b6fec16a93e1110d1489cef > change-id: 20240215-mmc-fix-davinci-bda788e8ee69 > > Best regards, > -- > Linus Walleij <linus.walleij@linaro.org> > Good catch Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On Thu, 15 Feb 2024 at 14:28, Linus Walleij <linus.walleij@linaro.org> wrote: > > The sg_miter conversion left a dangling unused variable. > Drop it. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202402142042.vg0lnLdb-lkp@intel.com/ > Fixes: ed01d210fd91 ("mmc: davinci_mmc: Use sg_miter for PIO") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/davinci_mmc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c > index c46577305138..8bd938919687 100644 > --- a/drivers/mmc/host/davinci_mmc.c > +++ b/drivers/mmc/host/davinci_mmc.c > @@ -211,7 +211,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, > unsigned int n) > { > struct sg_mapping_iter *sgm = &host->sg_miter; > - size_t sglen; > u8 *p; > unsigned int i; > > @@ -224,7 +223,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, > return; > } > p = sgm->addr; > - sglen = sgm->length; > > /* NOTE: we never transfer more than rw_threshold bytes > * to/from the fifo here; there's no I/O overlap. > > --- > base-commit: 26d7d52b6253574d5b6fec16a93e1110d1489cef > change-id: 20240215-mmc-fix-davinci-bda788e8ee69 > > Best regards, > -- > Linus Walleij <linus.walleij@linaro.org> >
diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index c46577305138..8bd938919687 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -211,7 +211,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, unsigned int n) { struct sg_mapping_iter *sgm = &host->sg_miter; - size_t sglen; u8 *p; unsigned int i; @@ -224,7 +223,6 @@ static void davinci_fifo_data_trans(struct mmc_davinci_host *host, return; } p = sgm->addr; - sglen = sgm->length; /* NOTE: we never transfer more than rw_threshold bytes * to/from the fifo here; there's no I/O overlap.
The sg_miter conversion left a dangling unused variable. Drop it. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202402142042.vg0lnLdb-lkp@intel.com/ Fixes: ed01d210fd91 ("mmc: davinci_mmc: Use sg_miter for PIO") Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mmc/host/davinci_mmc.c | 2 -- 1 file changed, 2 deletions(-) --- base-commit: 26d7d52b6253574d5b6fec16a93e1110d1489cef change-id: 20240215-mmc-fix-davinci-bda788e8ee69 Best regards,