| Message ID | 20240229142007.1278610-2-xiongwei.song@windriver.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] cgroup/cpuset: Remove cpuset_do_slab_mem_spread() | expand |
On 2/29/24 09:20, Xiongwei Song wrote: > We've removed the SLAG allocator, cpuset_do_slab_mem_spread() and Typo: "SLAG" --> SLAB. Other than that, Acked-by: Waiman Long <longman@redhat.com> > SLAB_MEM_SPREAD, memory_spread_slab is a no-op now. We can mark > memory_spread_slab as obsolete in case someone still wants to use it > after cpuset_do_slab_mem_spread() removed. For more details, please > check [1]. > > [1] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#m8e292e21b00f95a4bb8086371fa7387fa4ea8f60 > > Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com> > --- > Documentation/admin-guide/cgroup-v1/cpusets.rst | 2 +- > kernel/cgroup/cpuset.c | 3 +++ > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/admin-guide/cgroup-v1/cpusets.rst b/Documentation/admin-guide/cgroup-v1/cpusets.rst > index ae646d621a8a..88d0e7fa2ee0 100644 > --- a/Documentation/admin-guide/cgroup-v1/cpusets.rst > +++ b/Documentation/admin-guide/cgroup-v1/cpusets.rst > @@ -179,7 +179,7 @@ files describing that cpuset: > - cpuset.mem_hardwall flag: is memory allocation hardwalled > - cpuset.memory_pressure: measure of how much paging pressure in cpuset > - cpuset.memory_spread_page flag: if set, spread page cache evenly on allowed nodes > - - cpuset.memory_spread_slab flag: if set, spread slab cache evenly on allowed nodes > + - cpuset.memory_spread_slab flag: IT'S OBSOLETE. Please don't use it anymore > - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset > - cpuset.sched_relax_domain_level: the searching range when migrating tasks > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index ba36c073304a..728d06fe9382 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3897,6 +3897,9 @@ static struct cftype legacy_files[] = { > }, > > { > + /* It's obsolete. Please don't use it anymore. We will remove it > + * in the future. > + */ > .name = "memory_spread_slab", > .read_u64 = cpuset_read_u64, > .write_u64 = cpuset_write_u64,
Hello, Applied to cgroup/for-6.9 with some adjustments. Thanks. ----- 8< ----- From 3ab67a9ce82ff22447b1dad53b49a91d1abbf1ff Mon Sep 17 00:00:00 2001 From: Xiongwei Song <xiongwei.song@windriver.com> Date: Thu, 29 Feb 2024 22:20:07 +0800 Subject: [PATCH] cgroup/cpuset: Mark memory_spread_slab as obsolete We've removed the SLAB allocator, cpuset_do_slab_mem_spread() and SLAB_MEM_SPREAD, memory_spread_slab is a no-op now. We can mark memory_spread_slab as obsolete in case someone still wants to use it after cpuset_do_slab_mem_spread() removed. For more details, please check [1]. [1] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#m8e292e21b00f95a4bb8086371fa7387fa4ea8f60 tj: Description and cosmetic updates. Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com> Acked-by: Waiman Long <longman@redhat.com> Signed-off-by: Tejun Heo <tj@kernel.org> --- Documentation/admin-guide/cgroup-v1/cpusets.rst | 2 +- kernel/cgroup/cpuset.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/admin-guide/cgroup-v1/cpusets.rst b/Documentation/admin-guide/cgroup-v1/cpusets.rst index ae646d621a8a..7d3415eea05d 100644 --- a/Documentation/admin-guide/cgroup-v1/cpusets.rst +++ b/Documentation/admin-guide/cgroup-v1/cpusets.rst @@ -179,7 +179,7 @@ containing (on top of the standard cgroup files) the following - cpuset.mem_hardwall flag: is memory allocation hardwalled - cpuset.memory_pressure: measure of how much paging pressure in cpuset - cpuset.memory_spread_page flag: if set, spread page cache evenly on allowed nodes - - cpuset.memory_spread_slab flag: if set, spread slab cache evenly on allowed nodes + - cpuset.memory_spread_slab flag: OBSOLETE. Doesn't have any function. - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset - cpuset.sched_relax_domain_level: the searching range when migrating tasks diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index ba36c073304a..c940cf01b148 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3897,6 +3897,7 @@ static struct cftype legacy_files[] = { }, { + /* obsolete, may be removed in the future */ .name = "memory_spread_slab", .read_u64 = cpuset_read_u64, .write_u64 = cpuset_write_u64,
diff --git a/Documentation/admin-guide/cgroup-v1/cpusets.rst b/Documentation/admin-guide/cgroup-v1/cpusets.rst index ae646d621a8a..88d0e7fa2ee0 100644 --- a/Documentation/admin-guide/cgroup-v1/cpusets.rst +++ b/Documentation/admin-guide/cgroup-v1/cpusets.rst @@ -179,7 +179,7 @@ files describing that cpuset: - cpuset.mem_hardwall flag: is memory allocation hardwalled - cpuset.memory_pressure: measure of how much paging pressure in cpuset - cpuset.memory_spread_page flag: if set, spread page cache evenly on allowed nodes - - cpuset.memory_spread_slab flag: if set, spread slab cache evenly on allowed nodes + - cpuset.memory_spread_slab flag: IT'S OBSOLETE. Please don't use it anymore - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset - cpuset.sched_relax_domain_level: the searching range when migrating tasks diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index ba36c073304a..728d06fe9382 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3897,6 +3897,9 @@ static struct cftype legacy_files[] = { }, { + /* It's obsolete. Please don't use it anymore. We will remove it + * in the future. + */ .name = "memory_spread_slab", .read_u64 = cpuset_read_u64, .write_u64 = cpuset_write_u64,
We've removed the SLAG allocator, cpuset_do_slab_mem_spread() and SLAB_MEM_SPREAD, memory_spread_slab is a no-op now. We can mark memory_spread_slab as obsolete in case someone still wants to use it after cpuset_do_slab_mem_spread() removed. For more details, please check [1]. [1] https://lore.kernel.org/lkml/32bc1403-49da-445a-8c00-9686a3b0d6a3@redhat.com/T/#m8e292e21b00f95a4bb8086371fa7387fa4ea8f60 Signed-off-by: Xiongwei Song <xiongwei.song@windriver.com> --- Documentation/admin-guide/cgroup-v1/cpusets.rst | 2 +- kernel/cgroup/cpuset.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)