| Message ID | 20240307122129.2359553-1-usama.anjum@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: dw_mmc: remove unneeded assignment | expand |
On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote: > The err is being set to 0 and replaced every time after this > assignment. Remove this assignment as it is extraneous. > > Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c > index 989ae8dda7228..96af693e3e37c 100644 > --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c > +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c > @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, > goto tuning_out; > > prev_err = err; > - err = 0; Same for dw_mmc-hi3798cv200.c, maybe fix it as well? > } > > tuning_out:
Il 07/03/24 13:21, Muhammad Usama Anjum ha scritto: > The err is being set to 0 and replaced every time after this > assignment. Remove this assignment as it is extraneous. > > Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 3/7/24 5:22 PM, Yang Xiwen wrote: > On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote: >> The err is being set to 0 and replaced every time after this >> assignment. Remove this assignment as it is extraneous. >> >> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> >> --- >> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c >> b/drivers/mmc/host/dw_mmc-hi3798mv200.c >> index 989ae8dda7228..96af693e3e37c 100644 >> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c >> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c >> @@ -133,7 +133,6 @@ static int >> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, >> goto tuning_out; >> prev_err = err; >> - err = 0; > > > Same for dw_mmc-hi3798cv200.c, maybe fix it as well? Sent separately as different Fixes tag is required for that: https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com > > >> } >> tuning_out: > >
On Thu, Mar 07, 2024 at 07:51:37PM +0500, Muhammad Usama Anjum wrote: > On 3/7/24 5:22 PM, Yang Xiwen wrote: > > On 3/7/2024 8:21 PM, Muhammad Usama Anjum wrote: > >> The err is being set to 0 and replaced every time after this > >> assignment. Remove this assignment as it is extraneous. > >> > >> Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") > >> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > >> --- > >> drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c > >> b/drivers/mmc/host/dw_mmc-hi3798mv200.c > >> index 989ae8dda7228..96af693e3e37c 100644 > >> --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c > >> +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c > >> @@ -133,7 +133,6 @@ static int > >> dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, > >> goto tuning_out; > >> prev_err = err; > >> - err = 0; > > > > > > Same for dw_mmc-hi3798cv200.c, maybe fix it as well? > Sent separately as different Fixes tag is required for that: > https://lore.kernel.org/all/20240307145013.2721326-1-usama.anjum@collabora.com > The subjects are identical though. regards, dan carpenter
Soft reminder On 3/7/24 5:21 PM, Muhammad Usama Anjum wrote: > The err is being set to 0 and replaced every time after this > assignment. Remove this assignment as it is extraneous. > > Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c > index 989ae8dda7228..96af693e3e37c 100644 > --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c > +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c > @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, > goto tuning_out; > > prev_err = err; > - err = 0; > } > > tuning_out:
On Thu, 7 Mar 2024 at 13:21, Muhammad Usama Anjum <usama.anjum@collabora.com> wrote: > > The err is being set to 0 and replaced every time after this > assignment. Remove this assignment as it is extraneous. > > Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") Again, this isn't needed I think, so I have dropped it. > Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Applied for next and by amending the commit message prefix to "mmc: dw_mmc-hi3798mv200", thanks! Kind regards Uffe > --- > drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c > index 989ae8dda7228..96af693e3e37c 100644 > --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c > +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c > @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, > goto tuning_out; > > prev_err = err; > - err = 0; > } > > tuning_out: > -- > 2.39.2 >
diff --git a/drivers/mmc/host/dw_mmc-hi3798mv200.c b/drivers/mmc/host/dw_mmc-hi3798mv200.c index 989ae8dda7228..96af693e3e37c 100644 --- a/drivers/mmc/host/dw_mmc-hi3798mv200.c +++ b/drivers/mmc/host/dw_mmc-hi3798mv200.c @@ -133,7 +133,6 @@ static int dw_mci_hi3798mv200_execute_tuning_mix_mode(struct dw_mci_slot *slot, goto tuning_out; prev_err = err; - err = 0; } tuning_out:
The err is being set to 0 and replaced every time after this assignment. Remove this assignment as it is extraneous. Fixes: 25d043841db1 ("mmc: dw_mmc: add support for hi3798mv200") Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> --- drivers/mmc/host/dw_mmc-hi3798mv200.c | 1 - 1 file changed, 1 deletion(-)