| Message ID | 20240313133744.2405325-1-mikko.rapeli@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] mmc core block.c: initialize mmc_blk_ioc_data | expand |
On Wed, Mar 13, 2024 at 04:23:04PM +0200, Adrian Hunter wrote: > On 13/03/24 15:37, mikko.rapeli@linaro.org wrote: > > From: Mikko Rapeli <mikko.rapeli@linaro.org> > > > > Commit "mmc: core: Use mrq.sbc in close-ended ffu" adds flags uint to > > struct mmc_blk_ioc_data but it does not get initialized for RPMB ioctls > > which now fail. > > > > Fix this by always initializing the struct and flags to zero. > > > > Fixes access to RPMB storage. > > > > Fixes: 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu") > > > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218587 > > > > Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/ > > > > Cc: Avri Altman <avri.altman@wdc.com> > > Cc: Ulf Hansson <ulf.hansson@linaro.org> > > Cc: Adrian Hunter <adrian.hunter@intel.com> > > Cc: linux-mmc@vger.kernel.org > > Cc: stable@vger.kernel.org > > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> > > Not used to seeing blank lines after Fixes:, Closes, Link: tags, > nevertheless: From what I know no spaces in between the tags at the end of the commit message is just required. Having empty line there might break some tooling and automation. > Acked-by: Adrian Hunter <adrian.hunter@intel.com> Tested-by: Francesco Dolcini <francesco.dolcini@toradex.com> Ulf, Adrian: the bug these 2 patches are fixing is now in LTS kernel, it would be beneficial to have the fix in mainline ASAP. Francesco
+ Francesco Dolcini On Wed, 13 Mar 2024 at 14:57, <mikko.rapeli@linaro.org> wrote: > > From: Mikko Rapeli <mikko.rapeli@linaro.org> > > Commit "mmc: core: Use mrq.sbc in close-ended ffu" adds flags uint to > struct mmc_blk_ioc_data but it does not get initialized for RPMB ioctls > which now fail. > > Fix this by always initializing the struct and flags to zero. > > Fixes access to RPMB storage. > > Fixes: 4d0c8d0aef63 ("mmc: core: Use mrq.sbc in close-ended ffu") > > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218587 > > Link: https://lore.kernel.org/all/20231129092535.3278-1-avri.altman@wdc.com/ > > Cc: Avri Altman <avri.altman@wdc.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Cc: Adrian Hunter <adrian.hunter@intel.com> > Cc: linux-mmc@vger.kernel.org > Cc: stable@vger.kernel.org > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org> Both patch1 and patch2 applied fixes, thanks! I took the liberty of updating the commit messages a bit and dropped some of the unessarry newlines. Kind regards Uffe > --- > drivers/mmc/core/block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c > index 32d49100dff5..0df627de9cee 100644 > --- a/drivers/mmc/core/block.c > +++ b/drivers/mmc/core/block.c > @@ -413,7 +413,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( > struct mmc_blk_ioc_data *idata; > int err; > > - idata = kmalloc(sizeof(*idata), GFP_KERNEL); > + idata = kzalloc(sizeof(*idata), GFP_KERNEL); > if (!idata) { > err = -ENOMEM; > goto out; > -- > 2.34.1 >
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 32d49100dff5..0df627de9cee 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -413,7 +413,7 @@ static struct mmc_blk_ioc_data *mmc_blk_ioctl_copy_from_user( struct mmc_blk_ioc_data *idata; int err; - idata = kmalloc(sizeof(*idata), GFP_KERNEL); + idata = kzalloc(sizeof(*idata), GFP_KERNEL); if (!idata) { err = -ENOMEM; goto out;