| Message ID | 20240904203154.253655-2-detlev.casanova@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: mmc: Add support for rk3576 eMMC | expand |
On Wed, Sep 04, 2024 at 04:30:58PM -0400, Detlev Casanova wrote: > The device is compatible with rk3588, so add an entry for the 2 > compatibles together. > > The rk3576 device has a power-domain that needs to be on for the eMMC to > be used. Add it as a requirement. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> > --- > .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 37 +++++++++++++++---- > 1 file changed, 29 insertions(+), 8 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 4 Sept 2024 at 22:32, Detlev Casanova <detlev.casanova@collabora.com> wrote: > > The device is compatible with rk3588, so add an entry for the 2 > compatibles together. > > The rk3576 device has a power-domain that needs to be on for the eMMC to > be used. Add it as a requirement. > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> Applied for next, thanks! Kind regards Uffe > --- > .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 37 +++++++++++++++---- > 1 file changed, 29 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index 80d50178d2e3..c3d5e0230af1 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -12,14 +12,18 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,rk3568-dwcmshc > - - rockchip,rk3588-dwcmshc > - - snps,dwcmshc-sdhci > - - sophgo,cv1800b-dwcmshc > - - sophgo,sg2002-dwcmshc > - - sophgo,sg2042-dwcmshc > - - thead,th1520-dwcmshc > + oneOf: > + - items: > + - const: rockchip,rk3576-dwcmshc > + - const: rockchip,rk3588-dwcmshc > + - enum: > + - rockchip,rk3568-dwcmshc > + - rockchip,rk3588-dwcmshc > + - snps,dwcmshc-sdhci > + - sophgo,cv1800b-dwcmshc > + - sophgo,sg2002-dwcmshc > + - sophgo,sg2042-dwcmshc > + - thead,th1520-dwcmshc > > reg: > maxItems: 1 > @@ -35,6 +39,9 @@ properties: > minItems: 1 > maxItems: 5 > > + power-domains: > + maxItems: 1 > + > resets: > maxItems: 5 > > @@ -97,6 +104,20 @@ allOf: > - const: block > - const: timer > > + - if: > + properties: > + compatible: > + contains: > + const: rockchip,rk3576-dwcmshc > + > + then: > + required: > + - power-domains > + > + else: > + properties: > + power-domains: false > + > unevaluatedProperties: false > > examples: > -- > 2.46.0 >
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index 80d50178d2e3..c3d5e0230af1 100644 --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml @@ -12,14 +12,18 @@ maintainers: properties: compatible: - enum: - - rockchip,rk3568-dwcmshc - - rockchip,rk3588-dwcmshc - - snps,dwcmshc-sdhci - - sophgo,cv1800b-dwcmshc - - sophgo,sg2002-dwcmshc - - sophgo,sg2042-dwcmshc - - thead,th1520-dwcmshc + oneOf: + - items: + - const: rockchip,rk3576-dwcmshc + - const: rockchip,rk3588-dwcmshc + - enum: + - rockchip,rk3568-dwcmshc + - rockchip,rk3588-dwcmshc + - snps,dwcmshc-sdhci + - sophgo,cv1800b-dwcmshc + - sophgo,sg2002-dwcmshc + - sophgo,sg2042-dwcmshc + - thead,th1520-dwcmshc reg: maxItems: 1 @@ -35,6 +39,9 @@ properties: minItems: 1 maxItems: 5 + power-domains: + maxItems: 1 + resets: maxItems: 5 @@ -97,6 +104,20 @@ allOf: - const: block - const: timer + - if: + properties: + compatible: + contains: + const: rockchip,rk3576-dwcmshc + + then: + required: + - power-domains + + else: + properties: + power-domains: false + unevaluatedProperties: false examples:
The device is compatible with rk3588, so add an entry for the 2 compatibles together. The rk3576 device has a power-domain that needs to be on for the eMMC to be used. Add it as a requirement. Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com> --- .../bindings/mmc/snps,dwcmshc-sdhci.yaml | 37 +++++++++++++++---- 1 file changed, 29 insertions(+), 8 deletions(-)