| Message ID | 20241224094920.3821861-3-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | rockchip: Add rk3562 support | expand |
On Tue, 24 Dec 2024 17:49:05 +0800, Kever Yang wrote: > rk3562 is using the same controller as rk3588. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: None > > .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.example.dtb: mmc@fe310000: compatible: 'oneOf' conditional failed, one must be fixed: ['rockchip,rk3568-dwcmshc'] is too short 'rockchip,rk3568-dwcmshc' is not one of ['snps,dwcmshc-sdhci', 'sophgo,cv1800b-dwcmshc', 'sophgo,sg2002-dwcmshc', 'sophgo,sg2042-dwcmshc', 'thead,th1520-dwcmshc'] 'rockchip,rk3568-dwcmshc' is not one of ['rockchip,rk3562-dwcmshc', 'rockchip,rk3576-dwcmshc'] from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.example.dtb: mmc@fe310000: Unevaluated properties are not allowed ('compatible' was unexpected) from schema $id: http://devicetree.org/schemas/mmc/snps,dwcmshc-sdhci.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241224094920.3821861-3-kever.yang@rock-chips.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi Kever, Am Dienstag, 24. Dezember 2024, 10:49:05 CET schrieb Kever Yang: > rk3562 is using the same controller as rk3588. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: None > > .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > index c3d5e0230af1..33f4288ff879 100644 > --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml > @@ -14,16 +14,19 @@ properties: > compatible: > oneOf: oneOf means what the naming suggests, the compatible needs to either follow the "items", the old one means: "rockchip,rk3576-dwcmshc", "rockchip,rk3588-dwcmshc" or the enum below, which means "one" element from the enum list. > - items: > - - const: rockchip,rk3576-dwcmshc > + - const: rockchip,rk3568-dwcmshc > - const: rockchip,rk3588-dwcmshc That means, both the rk3568 and rk3588 entries in the enum below need to stay, as they represent the single-value compatibles and the items above should definitly not mention the rk3568, but instead be modified to just include the rk3562. So just modify the items above to include it: - items: - enum: - rockchip,rk3562-dwcmshc - rockchip,rk3576-dwcmshc - const: rockchip,rk3588-dwcmshc > - enum: > - - rockchip,rk3568-dwcmshc > - - rockchip,rk3588-dwcmshc > - snps,dwcmshc-sdhci > - sophgo,cv1800b-dwcmshc > - sophgo,sg2002-dwcmshc > - sophgo,sg2042-dwcmshc > - thead,th1520-dwcmshc Heiko
diff --git a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml index c3d5e0230af1..33f4288ff879 100644 --- a/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml +++ b/Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml @@ -14,16 +14,19 @@ properties: compatible: oneOf: - items: - - const: rockchip,rk3576-dwcmshc + - const: rockchip,rk3568-dwcmshc - const: rockchip,rk3588-dwcmshc - enum: - - rockchip,rk3568-dwcmshc - - rockchip,rk3588-dwcmshc - snps,dwcmshc-sdhci - sophgo,cv1800b-dwcmshc - sophgo,sg2002-dwcmshc - sophgo,sg2042-dwcmshc - thead,th1520-dwcmshc + - items: + - enum: + - rockchip,rk3562-dwcmshc + - rockchip,rk3576-dwcmshc + - const: rockchip,rk3588-dwcmshc reg: maxItems: 1
rk3562 is using the same controller as rk3588. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v2: None .../devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)