From patchwork Thu Feb 17 04:09:04 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 569111 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1H49vht005165 for ; Thu, 17 Feb 2011 04:09:57 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751393Ab1BQEJx (ORCPT ); Wed, 16 Feb 2011 23:09:53 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:51441 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981Ab1BQEJx (ORCPT ); Wed, 16 Feb 2011 23:09:53 -0500 Received: from epmmp2 (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Oracle Communications Messaging Exchange Server 7u4-19.01 64bit (built Sep 7 2010)) with ESMTP id <0LGQ002JAU7UPJE0@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Thu, 17 Feb 2011 13:09:30 +0900 (KST) Received: from TNRNDGASPAPP1.tn.corp.samsungelectronics.net ([165.213.149.150]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LGQ00A6XU7U8V@mmp2.samsung.com> for linux-mmc@vger.kernel.org; Thu, 17 Feb 2011 13:09:30 +0900 (KST) Received: from [165.213.219.108] ([165.213.219.108]) by TNRNDGASPAPP1.tn.corp.samsungelectronics.net with Microsoft SMTPSVC(6.0.3790.4675); Thu, 17 Feb 2011 13:09:30 +0900 Date: Thu, 17 Feb 2011 13:09:04 +0900 From: Jaehoon Chung Subject: Re: [PATCH] dw_mmc: modify quirks bit-shift control In-reply-to: <20110216194232.GA17634@void.printf.net> To: Chris Ball Cc: "linux-mmc@vger.kernel.org" , Will Newton , Kyungmin Park Message-id: <4D5C9F60.9020306@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7BIT User-Agent: Thunderbird 2.0.0.24 (X11/20100317) References: <4D5B6C70.2030809@samsung.com> <20110216194232.GA17634@void.printf.net> X-OriginalArrivalTime: 17 Feb 2011 04:09:30.0257 (UTC) FILETIME=[7996F010:01CBCE58] Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 17 Feb 2011 04:09:57 +0000 (UTC) diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h index 16b0261..3f22c20 100644 --- a/include/linux/mmc/dw_mmc.h +++ b/include/linux/mmc/dw_mmc.h @@ -165,14 +165,12 @@ struct dw_mci_dma_ops { }; /* IP Quirks/flags. */ -/* No special quirks or flags to cater for */ -#define DW_MCI_QUIRK_NONE 0 /* DTO fix for command transmission with IDMAC configured */ -#define DW_MCI_QUIRK_IDMAC_DTO 1 +#define DW_MCI_QUIRK_IDMAC_DTO BIT(0) /* delay needed between retries on some 2.11a implementations */ -#define DW_MCI_QUIRK_RETRY_DELAY 2 +#define DW_MCI_QUIRK_RETRY_DELAY BIT(1) /* High Speed Capable - Supports HS cards (upto 50MHz) */ -#define DW_MCI_QUIRK_HIGHSPEED 4 +#define DW_MCI_QUIRK_HIGHSPEED BIT(2) struct dma_pdata;