From patchwork Fri Aug 2 14:08:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 2837942 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0478FBF535 for ; Fri, 2 Aug 2013 14:09:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 898DC20418 for ; Fri, 2 Aug 2013 14:09:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D10A020184 for ; Fri, 2 Aug 2013 14:09:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038Ab3HBOJA (ORCPT ); Fri, 2 Aug 2013 10:09:00 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:35720 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948Ab3HBOI7 (ORCPT ); Fri, 2 Aug 2013 10:08:59 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MQW00JXDPYX1HO0@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Fri, 02 Aug 2013 23:08:57 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.112]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id F6.3A.17404.97DBBF15; Fri, 02 Aug 2013 23:08:57 +0900 (KST) X-AuditID: cbfee68d-b7f096d0000043fc-11-51fbbd798350 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F4.E5.31505.97DBBF15; Fri, 02 Aug 2013 23:08:57 +0900 (KST) Received: from [10.252.81.186] by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MQW00DN5PYXTL90@mmp2.samsung.com>; Fri, 02 Aug 2013 23:08:57 +0900 (KST) Message-id: <51FBBD7A.4050501@samsung.com> Date: Fri, 02 Aug 2013 23:08:58 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-version: 1.0 To: "linux-mmc@vger.kernel.org" Cc: 'Chris Ball' , Kyungmin Park , =?ISO-8859-1?Q?Heiko_St=FCbner?= Subject: [PATCH v2 1/4] mmc: sdhci-s3c: fix the wrong register value, when clock is disabled Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEIsWRmVeSWpSXmKPExsWyRsSkQLdy7+9Agwmf5S22v97IZvH/0WtW i7NNb9gtjvzvZ3Rg8Th0ZS2jR9+WVYwe26/NY/b4vEkugCWKyyYlNSezLLVI3y6BK6PlzlGm gkMcFbOnHGRpYPzJ1sXIySEhYCJx/2gvI4QtJnHh3nqgOBeHkMBSRonLB/7BFc1v28EMYgsJ TGeU+LWXE6LoNaNEd+88sG5eAS2J7tkfWEFsFgFViQ97p4PF2QR0JLZ/O84EYosKhEks+faY DaJeUOLH5HssXYwcHCIC1hLNv2VBZjILNDFKfNkzhR2kRlggTuLL3Elgc5iB5uxvncYGYctL bF7zlhmkQUJgHrvEm85OdojFAhLfJh8CGyohICux6QAzxAOSEgdX3GCZwCgyC8nqWUjGzkIy dgEj8ypG0dSC5ILipPQiQ73ixNzi0rx0veT83E2MwPg4/e9Z7w7G2wesDzEmA62cyCwlmpwP jK+8knhDYzMjC1MTU2Mjc0sz0oSVxHnVWqwDhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTAG aH9kT3q7p/LJXPHPm+67tpw6ytj15PaMSFYR40/eDR+uKdq5yZQk2k1X/Oq4Qeha93114fMf hFqVzflTTEXzb33qkM2c5B34+I/tbvZH/wy6vbNn3rdI6JrNvts+e+J5//RIPZcsg3pm6zUa 8+dWbVt62Hp6r9PbuDkylVsbzk/hklwvskuJpTgj0VCLuag4EQAZptlqpQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsVy+t9jQd3Kvb8DDZbPkLDY/nojm8X/R69Z Lc42vWG3OPK/n9GBxePQlbWMHn1bVjF6bL82j9nj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCGsaMljtHmQoOcVTMnnKQpYHxJ1sXIyeHhICJxPy2HcwQtpjEhXvr weJCAtMZJX7t5exi5AKyXzNKdPfOYwRJ8ApoSXTP/sAKYrMIqEp82DsdLM4moCOx/dtxJhBb VCBMYsm3x2wQ9YISPybfY+li5OAQEbCWaP4tCzKTWaCJUeLLninsIDXCAnESX+ZOApvDDDRn f+s0NghbXmLzmrfMExj5ZiEZNQtJ2SwkZQsYmVcxiqYWJBcUJ6XnGukVJ+YWl+al6yXn525i BEffM+kdjKsaLA4xCnAwKvHwPsj8FSjEmlhWXJl7iFGCg1lJhPfPbKAQb0piZVVqUX58UWlO avEhxmSgTycyS4km5wMTQ15JvKGxiZmRpZG5oYWRsTlpwkrivAdbrQOFBNITS1KzU1MLUotg tjBxcEo1MHbN2ugcd47vwmn9gzkp206Zn9GXyV7ba1DnuGiezszPCh/M3BoXyMoEXXn2sMf1 27+6w7rW6pxyFT+WzzS+k9Rj0z/JcvaKw5quPyY8XX03ZnGza5P4zcOzzCL6JyhrxfUt9T+2 67XFNP3/Z05xXm/+9tU6Wuec29fqShYD306B+fVWdcs+LFNiKc5INNRiLipOBADZUypRAgMA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When use the QUIRK_NONSTANDARD_CLOCK, then never set to 0 at clock control register. This patch is fixed this problem. ([PATCHv2] mmc: sdhci-s3c: fix teh wrong register value, when clock is disabled) Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- Changelog v2: - modified the comment drivers/mmc/host/sdhci-s3c.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 926aaf6..1572b6a 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -296,9 +296,12 @@ static void sdhci_cmu_set_clock(struct sdhci_host *host, unsigned int clock) unsigned long timeout; u16 clk = 0; - /* don't bother if the clock is going off */ - if (clock == 0) + /* If the clock is going off, set to 0 at clock control register */ + if (clock == 0) { + sdhci_writew(host, 0, SDHCI_CLOCK_CONTROL); + host->clock = clock; return; + } sdhci_s3c_set_clock(host, clock);