diff mbox

[v4,5/7] mmc: dw_mmc: remove the unnecessary function.

Message ID 5313EABD.3010804@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jaehoon Chung March 3, 2014, 2:36 a.m. UTC
Remove unnecessary function.
This function didn't re-use anywhere.

Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
Changelog V4:
	- None
Changelog V3:
	- None
Changelog V2:
	- None

 drivers/mmc/host/dw_mmc.c |    8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

Comments

Ulf Hansson March 6, 2014, 7:32 a.m. UTC | #1
On 3 March 2014 03:36, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Remove unnecessary function.
> This function didn't re-use anywhere.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

> ---
> Changelog V4:
>         - None
> Changelog V3:
>         - None
> Changelog V2:
>         - None
>
>  drivers/mmc/host/dw_mmc.c |    8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index ac16308..1418d33 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -235,12 +235,6 @@ err:
>  }
>  #endif /* defined(CONFIG_DEBUG_FS) */
>
> -static void dw_mci_set_timeout(struct dw_mci *host)
> -{
> -       /* timeout (maximum) */
> -       mci_writel(host, TMOUT, 0xffffffff);
> -}
> -
>  static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd)
>  {
>         struct mmc_data *data;
> @@ -861,7 +855,7 @@ static void __dw_mci_start_request(struct dw_mci *host,
>
>         data = cmd->data;
>         if (data) {
> -               dw_mci_set_timeout(host);
> +               mci_writel(host, TMOUT, 0xFFFFFFFF);
>                 mci_writel(host, BYTCNT, data->blksz*data->blocks);
>                 mci_writel(host, BLKSIZ, data->blksz);
>         }
> --
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index ac16308..1418d33 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -235,12 +235,6 @@  err:
 }
 #endif /* defined(CONFIG_DEBUG_FS) */
 
-static void dw_mci_set_timeout(struct dw_mci *host)
-{
-	/* timeout (maximum) */
-	mci_writel(host, TMOUT, 0xffffffff);
-}
-
 static u32 dw_mci_prepare_command(struct mmc_host *mmc, struct mmc_command *cmd)
 {
 	struct mmc_data	*data;
@@ -861,7 +855,7 @@  static void __dw_mci_start_request(struct dw_mci *host,
 
 	data = cmd->data;
 	if (data) {
-		dw_mci_set_timeout(host);
+		mci_writel(host, TMOUT, 0xFFFFFFFF);
 		mci_writel(host, BYTCNT, data->blksz*data->blocks);
 		mci_writel(host, BLKSIZ, data->blksz);
 	}