From patchwork Sat Nov 18 09:33:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064653 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 575BF60230 for ; Sat, 18 Nov 2017 09:36:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 446172A682 for ; Sat, 18 Nov 2017 09:36:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 369182A891; Sat, 18 Nov 2017 09:36:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC6712A682 for ; Sat, 18 Nov 2017 09:36:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161857AbdKRJfT (ORCPT ); Sat, 18 Nov 2017 04:35:19 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35942 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163261AbdKRJeb (ORCPT ); Sat, 18 Nov 2017 04:34:31 -0500 Received: by mail-pg0-f67.google.com with SMTP id t10so3758098pgo.3; Sat, 18 Nov 2017 01:34:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=BdyLi9FjKAcopuKRh9sSVffYvZNgeLxHTIjfX+hJpUg=; b=qW3mUncKV4+SOZJvrjLWNX2PKO1jvUtxsLlnrcqNo5LLKlrvra5nqeJw7vwBfuFm7O RvlTX8oINnRdg4HaWdM+60seqnCxIzS9frW6sduwalNYKpv6Mbp+p9DXfXWeZl/Tp1f/ W3VCc/HfbvN0SkRMwz14VdeNNLW8duwKc3qC3K//0pBrUuB5B1W6DEoZA+Qwtnaqv2ZB WnNV/T7Jw7+xDOo35K3R+fESpfp38tvFNfNgrLl6KLChK1oMsnpw5o+NmmOmbcY2xOyN l8oUWx7lTpn1eMUP47LTKX2bfaCbOfiiCDwCPHz0FJ7D82rQlUV83ukvuQQKA8Dwg74/ 46iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=BdyLi9FjKAcopuKRh9sSVffYvZNgeLxHTIjfX+hJpUg=; b=iQukgWg5dZcMHbXwHiHRHcKIH7yWfUEunbdbK4fgaphqxiSd92lH2Qjp4g83KUaPNv S8rKX2SLYQz1WGMblB89bqIc2tvBvhpVXKPYN4/5hfw7gJ7MYSBkvjI60u5Ua7kJD1RO AbxyWL/G4JRJXWn4FJvsA4vW4ff+P2eM3WqLVlpdyohtkqPePYjaKOs9KgmhBjD8DwoJ j0/UCHG1NhaG0YPgRqurK2HQeOQ7fSyMoROYPug4YTXCQOrwqObZRIzDaAfFr3DfSBW1 35KJddO6uriQDWSLxMk8jFG4FHZ7WjV9d6biniPNsQD04pr7YtjLnEasFtKs5FL27pgl NSqQ== X-Gm-Message-State: AJaThX5E9hCvNPxSmg4QAqlorpNYCt392v06vhSVCeKBXzExzoqo0njE /ljINvuFw2GOEvOS7hByBHA= X-Google-Smtp-Source: AGs4zMaR4JIrH34EDT7jAL1RO5ce5uEC4eJqwg28HjEX3xJt0VXsXQ+xk+HxpoJ+eBND8ctt5ZwH2Q== X-Received: by 10.159.205.132 with SMTP id v4mr8078886plo.426.1510997670476; Sat, 18 Nov 2017 01:34:30 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id y20sm11057079pgc.52.2017.11.18.01.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 01:34:29 -0800 (PST) From: Arvind Yadav To: ben-linux@fluff.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, carlo@caione.org, khilman@baylibre.com Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: [PATCH 5/6 v2] mmc: sh_mmcif: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 15:03:47 +0530 Message-Id: <59e155d8c3eff4adf39cd343c56e52530020f64d.1510997223.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> References: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> References: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/mmc/host/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 53fb18b..481f2c4 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev) irq[0] = platform_get_irq(pdev, 0); irq[1] = platform_get_irq(pdev, 1); - if (irq[0] < 0) { + if (irq[0] <= 0 || irq[1] <= 0) { dev_err(dev, "Get irq error\n"); return -ENXIO; }