| Message ID | 68d689c39c769d298b53ee8cb9de0e594a2999b2.1645460780.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | mmc: sh_mmcif: Simplify division/shift logic | expand |
On Mon, 21 Feb 2022 at 17:27, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > "a / (1 << b)" == "a >> b". > > No change in generated code. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sh_mmcif.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c > index 104dcd702870c423..5f9ebf045b1cb22b 100644 > --- a/drivers/mmc/host/sh_mmcif.c > +++ b/drivers/mmc/host/sh_mmcif.c > @@ -521,8 +521,7 @@ static void sh_mmcif_clock_control(struct sh_mmcif_host *host, unsigned int clk) > } > > dev_dbg(dev, "clk %u/%u (%u, 0x%x)\n", > - (best_freq / (1 << (clkdiv + 1))), clk, > - best_freq, clkdiv); > + (best_freq >> (clkdiv + 1)), clk, best_freq, clkdiv); > > clk_set_rate(host->clk, best_freq); > clkdiv = clkdiv << 16; > @@ -1012,8 +1011,8 @@ static void sh_mmcif_clk_setup(struct sh_mmcif_host *host) > */ > host->clkdiv_map = 0x3ff; > > - host->mmc->f_max = f_max / (1 << ffs(host->clkdiv_map)); > - host->mmc->f_min = f_min / (1 << fls(host->clkdiv_map)); > + host->mmc->f_max = f_max >> ffs(host->clkdiv_map); > + host->mmc->f_min = f_min >> fls(host->clkdiv_map); > } else { > unsigned int clk = clk_get_rate(host->clk); > > -- > 2.25.1 >
On Mon, Feb 21, 2022 at 05:27:20PM +0100, Geert Uytterhoeven wrote: > "a / (1 << b)" == "a >> b". > > No change in generated code. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Better late than never :/ Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 104dcd702870c423..5f9ebf045b1cb22b 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -521,8 +521,7 @@ static void sh_mmcif_clock_control(struct sh_mmcif_host *host, unsigned int clk) } dev_dbg(dev, "clk %u/%u (%u, 0x%x)\n", - (best_freq / (1 << (clkdiv + 1))), clk, - best_freq, clkdiv); + (best_freq >> (clkdiv + 1)), clk, best_freq, clkdiv); clk_set_rate(host->clk, best_freq); clkdiv = clkdiv << 16; @@ -1012,8 +1011,8 @@ static void sh_mmcif_clk_setup(struct sh_mmcif_host *host) */ host->clkdiv_map = 0x3ff; - host->mmc->f_max = f_max / (1 << ffs(host->clkdiv_map)); - host->mmc->f_min = f_min / (1 << fls(host->clkdiv_map)); + host->mmc->f_max = f_max >> ffs(host->clkdiv_map); + host->mmc->f_min = f_min >> fls(host->clkdiv_map); } else { unsigned int clk = clk_get_rate(host->clk);
"a / (1 << b)" == "a >> b". No change in generated code. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/mmc/host/sh_mmcif.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)