| Message ID | 6906e34b62f162018984a5fbd12b3ef6cd5e3a29.1438839562.git.michal.simek@xilinx.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 6 August 2015 at 07:39, Michal Simek <michal.simek@xilinx.com> wrote: > Add GPIOLIB dependency for MMC_SDHCI. > > Problem was observed after adding the patch > "mmc: sdhci-of-arasan: Call OF parsing for MMC" > (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls > mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which > calls devm_gpiod_get_index() which returns -ENOSYS. > > Error log: > sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) > sdhci-arasan: probe of ff160000.sdhci failed with error -38 > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> Thanks, applied for next! Kind regards Uffe > --- > > After RFC here https://lkml.org/lkml/2015/7/24/371 > adding dependency on MMC_SDHCI. > > --- > drivers/mmc/host/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index fd9a58e216a5..5519803c124b 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -38,6 +38,7 @@ config MMC_PXA > config MMC_SDHCI > tristate "Secure Digital Host Controller Interface support" > depends on HAS_DMA > + depends on GPIOLIB > help > This selects the generic Secure Digital Host Controller Interface. > It is used by manufacturers such as Texas Instruments(R), Ricoh(R) > -- > 2.3.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25 August 2015 at 14:04, Ulf Hansson <ulf.hansson@linaro.org> wrote: > On 6 August 2015 at 07:39, Michal Simek <michal.simek@xilinx.com> wrote: >> Add GPIOLIB dependency for MMC_SDHCI. >> >> Problem was observed after adding the patch >> "mmc: sdhci-of-arasan: Call OF parsing for MMC" >> (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls >> mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which >> calls devm_gpiod_get_index() which returns -ENOSYS. >> >> Error log: >> sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) >> sdhci-arasan: probe of ff160000.sdhci failed with error -38 >> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > > Thanks, applied for next! kbuild test robot reports a warning for this one, so I am dropping it from my next branch. ----- warning: (AKEBONO) selects MMC_SDHCI which has unmet direct dependencies (MMC && HAS_DMA && GPIOLIB) https://lists.01.org/pipermail/kbuild-all/2015-August/011824.html ----- Perhaps we should just live with this kind of configuration problems as this patch is trying to fix? Looking into drivers in general I don't think we normally specify all the Kconfig dependencies to be able to meet a successfully probe(). The GPIOLIB is just one thing out of many. Or you have a better idea? :-) Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index fd9a58e216a5..5519803c124b 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -38,6 +38,7 @@ config MMC_PXA config MMC_SDHCI tristate "Secure Digital Host Controller Interface support" depends on HAS_DMA + depends on GPIOLIB help This selects the generic Secure Digital Host Controller Interface. It is used by manufacturers such as Texas Instruments(R), Ricoh(R)
Add GPIOLIB dependency for MMC_SDHCI. Problem was observed after adding the patch "mmc: sdhci-of-arasan: Call OF parsing for MMC" (sha1: 16b23787fc709fe60c5d2bd05927b1a3da33d4e9) which calls mmc_of_parse() -> mmc_gpiod_request_cd() (slot-gpio.c) which calls devm_gpiod_get_index() which returns -ENOSYS. Error log: sdhci-arasan ff160000.sdhci: parsing dt failed (4294967258) sdhci-arasan: probe of ff160000.sdhci failed with error -38 Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- After RFC here https://lkml.org/lkml/2015/7/24/371 adding dependency on MMC_SDHCI. --- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+)