From patchwork Fri Mar 3 19:51:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 9603417 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5029560414 for ; Fri, 3 Mar 2017 20:00:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4198628631 for ; Fri, 3 Mar 2017 20:00:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3604328633; Fri, 3 Mar 2017 20:00:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B160428631 for ; Fri, 3 Mar 2017 20:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751958AbdCCUAl (ORCPT ); Fri, 3 Mar 2017 15:00:41 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36029 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbdCCUAk (ORCPT ); Fri, 3 Mar 2017 15:00:40 -0500 Received: by mail-wr0-f195.google.com with SMTP id l37so14500066wrc.3 for ; Fri, 03 Mar 2017 12:00:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=dLHqnsef16kf9M2aeYpF76wC6K5YmNuJi0sAsRylOeM=; b=LMBKoMgHU1owK520PU7jERIvW6NeWTxjAmDsUGQnzeM0k2Mc8F0FBergEs0YUob+P/ UVwXl/oCgi9FkHR8Q7Vb+Hio5F0sOWYNWYP5AmfkERIEmTDLTuntxeeOntWnWtAfmguo WpOT3s9pX5xOZuG4pDIVYnf3eEXeVNphixg22qAFkFOgSc6JlBUgpilKfLYtBuugYW7V OR9BT6n803E6Rfjh4BXRU7hMIYbWJTJ9ukFfimNoysrHv786nAu7LBbtYRZQNevT+4IF COAVx8dJz8rz2M1tT2ZEm0er68KSruRLjWSdn7uV50lOtB1c5uZsUe4Z3LBEuOpPrEZn 9JJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=dLHqnsef16kf9M2aeYpF76wC6K5YmNuJi0sAsRylOeM=; b=DabWNUyt2iC8LlNsP/7NSQ/Zerpmae5N7t+/BL6vji5ocB5/2rWYGvpA5m9nsL8YuP Zq3g6tM3Sf1rTSBOA0xXF4S+W4Uk8i6Uq3RmvwLX26WvfOPNIbbcj8ylILa3524u84FU 1DcuAT88bWI8Cm5pBSC1bTN+TbAH5Wp3+7/lqNybtV8MEE3c2v3Ru8sOVlGGeI6fpam/ iTRvQ1afSsvOdy68xQVgZn2ZPQRSb3VjbaRRNWyWhS3mYAeUYaNdblA0wy+Ezfa1j+aM vsEPteT8ExwUNS4asInrPcNEjNx7uu4nWT0UMeMq6R8jk3P8kR/sEXP7DPUTCJ/tVuOp LRxw== X-Gm-Message-State: AMke39kbhhlV0gqyP6sEcCGX/TFl7uw/9CqrXVxdltRrUQ6ocgdxH+LNQK056w49cRc/Bg== X-Received: by 10.223.177.207 with SMTP id r15mr4689878wra.127.1488571239014; Fri, 03 Mar 2017 12:00:39 -0800 (PST) Received: from ?IPv6:2003:c6:ebdc:4000:f903:fe11:afad:80a0? (p200300C6EBDC4000F903FE11AFAD80A0.dip0.t-ipconnect.de. [2003:c6:ebdc:4000:f903:fe11:afad:80a0]) by smtp.googlemail.com with ESMTPSA id t30sm16467272wra.52.2017.03.03.12.00.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Mar 2017 12:00:38 -0800 (PST) Subject: [PATCH v4 1/10] mmc: meson-gx: simplify bounce buffer setting in meson_mmc_start_cmd To: Ulf Hansson , Kevin Hilman References: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> Cc: "linux-mmc@vger.kernel.org" , linux-amlogic@lists.infradead.org From: Heiner Kallweit Message-ID: <6e9c0183-2c78-6c47-939c-4e65b3bec254@gmail.com> Date: Fri, 3 Mar 2017 20:51:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <62912f3d-2307-cfff-3c69-c8b8ffaeb474@gmail.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Core ensures that there are no commands with cmd->data being set and nothing to transfer. And we don't have to reset bit CMD_CFG_DATA_NUM because cmd_cfg was zero-initialized and this bit isn't set. Signed-off-by: Heiner Kallweit Acked-by: Kevin Hilman --- v2: - adjusted commit message because branch xfer_bytes == 0 is never reached - added acked-by v3: - no changes v4: - no changes --- drivers/mmc/host/meson-gx-mmc.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 5a959783..07a7399c 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -516,14 +516,7 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd) desc->cmd_cfg &= ~CMD_CFG_DATA_WR; } - if (xfer_bytes > 0) { - desc->cmd_cfg &= ~CMD_CFG_DATA_NUM; - desc->cmd_data = host->bounce_dma_addr & CMD_DATA_MASK; - } else { - /* write data to data_addr */ - desc->cmd_cfg |= CMD_CFG_DATA_NUM; - desc->cmd_data = 0; - } + desc->cmd_data = host->bounce_dma_addr & CMD_DATA_MASK; cmd_cfg_timeout = 12; } else {