| Message ID | 86mwdspk58.fsf@void.printf.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, Chris. Didn't you want to merge the below patch? https://patchwork.kernel.org/patch/4239541/ I have tested with exynos series, and working fine. Best Regards, Jaehoon Chung On 06/05/2014 04:08 AM, Chris Ball wrote: > "mmc: sdhci: push card_tasklet into threaded irq handler" removed > the card_tasklet, but it is still in use by sdhci-s3c.c. > > Signed-off-by: Chris Ball <chris@printf.net> > --- > Hi, > > sdhci-s3c is currently failing to build due to the removal of > card_tasklet. I think this trivial patch might do the right > thing -- please could someone test that card detection still > works and ACK if so? Thanks! > > drivers/mmc/host/sdhci-s3c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c > index 781b8a9..53a32e2 100644 > --- a/drivers/mmc/host/sdhci-s3c.c > +++ b/drivers/mmc/host/sdhci-s3c.c > @@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state) > clk_disable_unprepare(sc->clk_io); > #endif > } > - tasklet_schedule(&host->card_tasklet); > spin_unlock_irqrestore(&host->lock, flags); > } > } > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Jun 04 2014, Jaehoon Chung wrote: > Didn't you want to merge the below patch? > > https://patchwork.kernel.org/patch/4239541/ > > I have tested with exynos series, and working fine. Oops, of course -- thanks! Pushed to mmc-next for 3.16. - Chris.
diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 781b8a9..53a32e2 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -399,7 +399,6 @@ static void sdhci_s3c_notify_change(struct platform_device *dev, int state) clk_disable_unprepare(sc->clk_io); #endif } - tasklet_schedule(&host->card_tasklet); spin_unlock_irqrestore(&host->lock, flags); } }
"mmc: sdhci: push card_tasklet into threaded irq handler" removed the card_tasklet, but it is still in use by sdhci-s3c.c. Signed-off-by: Chris Ball <chris@printf.net> --- Hi, sdhci-s3c is currently failing to build due to the removal of card_tasklet. I think this trivial patch might do the right thing -- please could someone test that card detection still works and ACK if so? Thanks! drivers/mmc/host/sdhci-s3c.c | 1 - 1 file changed, 1 deletion(-)