From patchwork Thu Jun 9 03:23:59 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ohad Ben Cohen X-Patchwork-Id: 863102 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p593OLL1007024 for ; Thu, 9 Jun 2011 03:24:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755220Ab1FIDYU (ORCPT ); Wed, 8 Jun 2011 23:24:20 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:50119 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755140Ab1FIDYU (ORCPT ); Wed, 8 Jun 2011 23:24:20 -0400 Received: by wwa36 with SMTP id 36so1223468wwa.1 for ; Wed, 08 Jun 2011 20:24:19 -0700 (PDT) Received: by 10.216.197.168 with SMTP id t40mr195129wen.55.1307589859120; Wed, 08 Jun 2011 20:24:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.216.90.132 with HTTP; Wed, 8 Jun 2011 20:23:59 -0700 (PDT) X-Originating-IP: [46.116.119.47] In-Reply-To: References: <20110605123852.BC6F39D401C@zog.reactivated.net> From: Ohad Ben-Cohen Date: Thu, 9 Jun 2011 06:23:59 +0300 Message-ID: Subject: Re: [PATCH] mmc: sdio: reset card during power_restore To: Daniel Drake Cc: linux-mmc@vger.kernel.org Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 09 Jun 2011 03:24:22 +0000 (UTC) On Wed, Jun 8, 2011 at 11:58 PM, Daniel Drake wrote: >> Please reboot, and immediately after booting (without insmoding the >> driver) tell me what's the output of : >> >> mount -t debugfs none /sys/kernel/debug >> cat /sys/kernel/debug/mmc1/ios > > Which base kernel setup should I run these tests on? Vanilla, with your temporary patch below. Without this patch, mmc1 (I assume this what drives sd8686 in your setup) should be powered on. With it, it should be powered off. host->flags |= SDHCI_AUTO_CMD12; --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 58d5436..ce3e2e2 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2488,7 +2488,7 @@ int sdhci_add_host(struct sdhci_host *host) } else mmc->f_min = host->max_clk / SDHCI_MAX_DIV_SPEC_200; - mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23; + mmc->caps |= MMC_CAP_SDIO_IRQ | MMC_CAP_ERASE | MMC_CAP_CMD23 | MMC_CAP_POWER_OFF_CARD; if (host->quirks & SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12)