From patchwork Fri Jul 20 09:28:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkatraman S X-Patchwork-Id: 1220131 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id CB4F0DF24C for ; Fri, 20 Jul 2012 09:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751337Ab2GTJ2e (ORCPT ); Fri, 20 Jul 2012 05:28:34 -0400 Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:47619 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227Ab2GTJ2d (ORCPT ); Fri, 20 Jul 2012 05:28:33 -0400 Received: from mail-bk0-f46.google.com ([209.85.214.46]) (using TLSv1) by na3sys009aob107.postini.com ([74.125.148.12]) with SMTP ID DSNKUAkkv3pP6A4EbnzSb8ev2sQ77yZjsifr@postini.com; Fri, 20 Jul 2012 02:28:32 PDT Received: by bkwj10 with SMTP id j10so3165798bkw.19 for ; Fri, 20 Jul 2012 02:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=4b3qqvnUYjHdOTYshP8YjO8Bg0KjoYMYIE/ywA4Lylk=; b=RFuIplolT2j4l+o/kblezj3CNYPU9+wmD+16gXpgUPnTyrQKIgqKp9ipJew0EsN37I dn7COWPleqpHyfJhuYwUE3IW7lIhFTzSG/nLfZlzYDF3Stqbp8ASQYQVTAa6+LVsk7Jc VpL+ZBkybh8NGhFcyPBgwLF5XklBn8QmN8myOYYCT4Adwhv7KtH+LHyKfjgppnFh+SJL XC3hk51GN0Fa2j+OrkQHlmiuxSJt8m4gj1ZdOrZnvw4wTnK/d/ccVOoWG3SGnngzDCMy hWukTkWJvnjpEvjBIiV1xhq7nO33bMvtpiUIBQxXT2GPgggf/0he8nrFoEQy3AuGNKyH b4Vg== Received: by 10.204.130.10 with SMTP id q10mr2402773bks.90.1342776510351; Fri, 20 Jul 2012 02:28:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.205.119.8 with HTTP; Fri, 20 Jul 2012 02:28:10 -0700 (PDT) In-Reply-To: <20120719113246.GN6522@atomide.com> References: <20120718065951.GH6522@atomide.com> <20120718071039.GI6522@atomide.com> <20120719113246.GN6522@atomide.com> From: "S, Venkatraman" Date: Fri, 20 Jul 2012 14:58:10 +0530 Message-ID: Subject: Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default To: Tony Lindgren Cc: "Shilimkar, Santosh" , Javier Martinez Canillas , Javier Martinez Canillas , Kevin Hilman , Russell King , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Chris Ball , linux-mmc@vger.kernel.org X-Gm-Message-State: ALoCoQnQ/Xc4vhCHwR1Q1DggBUTaVo+QFAQOB8S7z6bA6/XLObVCW1YIIk2gktrU3Ard5j+a/Tap Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, Jul 19, 2012 at 5:02 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120718 02:49]: >> >> "The patch simply make them depend on DMA_OMAP since DMA_OMAP >> will select DMA_ENGINE automatically" >> >> This won't be true if the DMA selection are not done >> at ARCH_OMAP level as discussed in this thread. >> >> Having said that, I think Russell and Tony need to >> take call on how this needs to be handled. > > As the DMA channels can run out, drivers should also work > without DMA. And building everything as modules should be > possible for the distro kernels. > > So I'd rather not have either select or depends and have > the drivers fixed. > Ok - I'll work on getting polling mode to work, but as you know it's not the mode to get the best performance out of the device. I see that you've also merged the changes to omap2plus_defconfig, which should get MMC working as before DMA Engine conversion. There's a small patch needed to omap_hsmmc to return a non-zero error code during the probe error path. This will atleast make probe failure explicit when DMA is not available. Let me know if you want me to post it separately as a patch.. unsigned tx_req, rx_req; --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 2338703..892a046 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1773,7 +1773,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) struct mmc_host *mmc; struct omap_hsmmc_host *host = NULL; struct resource *res; - int ret, irq; + int ret = -ENXIO, irq; const struct of_device_id *match; dma_cap_mask_t mask;