From patchwork Tue May 16 15:37:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9729285 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D2051602B4 for ; Tue, 16 May 2017 15:37:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C203E1FFB7 for ; Tue, 16 May 2017 15:37:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B31C828A20; Tue, 16 May 2017 15:37:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83A9228A17 for ; Tue, 16 May 2017 15:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751917AbdEPPhK (ORCPT ); Tue, 16 May 2017 11:37:10 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:34724 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbdEPPhK (ORCPT ); Tue, 16 May 2017 11:37:10 -0400 Received: by mail-oi0-f54.google.com with SMTP id b204so30134994oii.1 for ; Tue, 16 May 2017 08:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1WHzsoVyCJT0o3U42LXf5VKLwbYSntyJ23D4MzOHHy8=; b=CQhwZs9M6zdtjOfEFetMoVtPsFMndsfSZVA21IT16iBpemyaoOLyvmYghWYBySsWsa w7i841p+pUP50caasJo6j3vataqP3EXzHU1HATthQbXUAzeJ9xeWgnxraNFhBLGOSBSH cDNNqbNOsbz+BKCOrhRHD4uR4lAR02BTPtsoR3L0gpCYcvyoqYscN7RN5hmxcvN4o0YA 1EjpBjJBh76pJ94UZlJTMgQk+TbW8LBmPU472eQlYLmHgdqhrZ+CAR10C3Vl8DASJk7C omN+b27McQh9azVFzvs9dETzh5ozmVYENPKubkqEdKcRH/rIUP0ULBdn4FCUeh3xatF+ 6C3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1WHzsoVyCJT0o3U42LXf5VKLwbYSntyJ23D4MzOHHy8=; b=CfgXvLNSZ8rXaYcntxQG7L98RackoZ23v7+9kj5Hu47TGNlSlbzKav+tv7FSR28jv0 PeaJoQ5/KiuMkmfAHX0z57StV78BWYeRj1XsKFz1CvAhkXWtmeAWmPxO8hDD1HvI2hRY 1n7Tafl6KaYvaEhw2v4VlVP7P0WY8gmXOfSRaNhU87flS+BjOOsxA8QN3lI4Kx4EjHuf hfW7hQvAPAtxA6C/8uw7jXVkie0RA5tB2CDsToMfJVGNI3vkUc0+Iudq9humt+SiBiWP 8LlNuQ2pf6E7X4NbxNBNE/NZWMjltIoe118s6+nW31KE1W9ASJuXK0cF0jp/3gnJEjmL ca5w== X-Gm-Message-State: AODbwcCTB9KQaDcYv9yEgVCklGjgKxfg7CwFqhs1j3kraQsfiWCFbysx 0NCz3M8N776Q8RNvbUtdIlhdeifzkg== X-Received: by 10.202.81.203 with SMTP id f194mr2385135oib.204.1494949029079; Tue, 16 May 2017 08:37:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.43.138 with HTTP; Tue, 16 May 2017 08:37:08 -0700 (PDT) In-Reply-To: References: From: Fabio Estevam Date: Tue, 16 May 2017 12:37:08 -0300 Message-ID: Subject: Re: imx7: mmc_select_hs200 failed, error -74 To: Dong Aisheng Cc: Adrian Hunter , "linux-mmc@vger.kernel.org" , Ulf Hansson , Stefan Agner , "linux-arm-kernel@lists.infradead.org" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, May 16, 2017 at 10:58 AM, Fabio Estevam wrote: > Hi, > > On a imx7s-warp board (sdhci-esdhc-imx.c driver) running 4.12-rc1 the > following mmc1 error message is seen: > > [ 1.796192] mmc1: mmc_select_hs200 failed, error -74 > [ 1.810220] mmc1: new MMC card at address 0001 > [ 1.823066] mmcblk1: mmc1:0001 V10008 7.05 GiB > [ 1.834155] mmcblk1boot0: mmc1:0001 V10008 partition 1 4.00 MiB > [ 1.841608] mmcblk1boot1: mmc1:0001 V10008 partition 2 4.00 MiB > [ 1.848971] mmcblk1rpmb: mmc1:0001 V10008 partition 3 4.00 MiB > [ 1.859576] mmcblk1: p1 p2 > > The rootfs can be mounted correctly from eMMC though. > > What is the proper way to fix the 'mmc_select_hs200 failed' error message? with the following changes: the card is probed as DDR MMC and the error message is gone: # dmesg | grep mmc1 [ 1.702797] mmc1: SDHCI controller on 30b60000.usdhc [30b60000.usdhc] using A [ 1.811211] mmc1: new DDR MMC card at address 0001 [ 1.820786] mmcblk1: mmc1:0001 V10008 7.05 GiB [ 1.833340] mmcblk1boot0: mmc1:0001 V10008 partition 1 4.00 MiB [ 1.840518] mmcblk1boot1: mmc1:0001 V10008 partition 2 4.00 MiB [ 1.847812] mmcblk1rpmb: mmc1:0001 V10008 partition 3 4.00 MiB Is this a correct fix? Thanks --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1454,7 +1454,7 @@ static int mmc_select_hs200(struct mmc_card *card) if (mmc_set_signal_voltage(host, old_signal_voltage)) err = -EIO; - pr_err("%s: %s failed, error %d\n", mmc_hostname(card->host), + pr_debug("%s: %s failed, error %d\n", mmc_hostname(card->host), __func__, err); } return err; @@ -1474,7 +1474,7 @@ static int mmc_select_timing(struct mmc_card *card) err = mmc_select_hs400es(card); else if (card->mmc_avail_type & EXT_CSD_CARD_TYPE_HS200) err = mmc_select_hs200(card); - else if (card->mmc_avail_type & EXT_CSD_CARD_TYPE_HS) + if (card->mmc_avail_type & EXT_CSD_CARD_TYPE_HS) err = mmc_select_hs(card); if (err && err != -EBADMSG)