diff mbox

mmc: core: Fix start_signal_voltage_switch argument type

Message ID CAOMZO5DKNmqiYs7wHSB5MktgxwczTrhn3fQA0Frkm=bNbUYUdw@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Feb. 14, 2013, 11:57 a.m. UTC 
Hi Ulf,

On Thu, Feb 14, 2013 at 8:33 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> No. Fixup shall be done in SDHCI instead. Otherwise other host drivers
> will break instead.

Do you mean like this?

        int ret;
@@ -1689,7 +1689,7 @@ static int
sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,

        ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2);

-       switch (signal_voltage) {
+       switch (ios->signal_voltage) {
        case MMC_SIGNAL_VOLTAGE_330:
                /* Set 1.8V Signal Enable in the Host Control2 register to 0 */
                ctrl &= ~SDHCI_CTRL_VDD_180;
@@ -1762,7 +1762,7 @@ static int
sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,
 }

 static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
-       int signal_voltage)
+       struct mmc_ios *ios)
 {
        struct sdhci_host *host = mmc_priv(mmc);
        int err;
@@ -1770,7 +1770,7 @@ static int
sdhci_start_signal_voltage_switch(struct mmc_host *mmc,
        if (host->version < SDHCI_SPEC_300)
                return 0;
        sdhci_runtime_pm_get(host);
-       err = sdhci_do_start_signal_voltage_switch(host, signal_voltage);
+       err = sdhci_do_start_signal_voltage_switch(host, ios);
        sdhci_runtime_pm_put(host);
        return err;
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1675,7 +1675,7 @@  static void sdhci_enable_sdio_irq(struct
mmc_host *mmc, int enable)
 }

 static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host,
-                                               int signal_voltage)
+                                               struct mmc_ios *ios)
 {
        u16 ctrl;