From patchwork Thu Feb 14 11:57:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 2141431 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 247633FCFC for ; Thu, 14 Feb 2013 11:58:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934129Ab3BNL6c (ORCPT ); Thu, 14 Feb 2013 06:58:32 -0500 Received: from mail-vc0-f170.google.com ([209.85.220.170]:37412 "EHLO mail-vc0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934253Ab3BNL5n (ORCPT ); Thu, 14 Feb 2013 06:57:43 -0500 Received: by mail-vc0-f170.google.com with SMTP id p16so1419047vcq.1 for ; Thu, 14 Feb 2013 03:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=0RnalWcmSt8iuyvZOesjviCpsVKVmR1d2cvEcD165nA=; b=Jg1i4Pn43aKILQlOz3F/FtsGhMcFrjDvWqR8+OQao9kQP02MQJ1DLIegut8SgIk4b+ gEEFV9Kcyfnmaj4CT8Tjte0mLlZ/EtCiiHzfLV4t047X4XbyKBvEWrb6jUt/BoU8a7dB bQDJHTTdQs7MQ5JXkAo0ltsPSLvVQvaNkCV8ZIBP/oSCPq7KVGZiItlfhx1WCtBNAGzU oxqCZG8Bdb944GTZFTvkMqcxFStGLPJhkv7jvbvyj4vaKspce+D2vgknco4ODxfT/3Et h+YVuX9IEGv4IHk/tBBQwpMF4XgB1NSK+aLZZCG4lICeo+wVeoxGIztn3XJLSQaSVB7D RnTQ== MIME-Version: 1.0 X-Received: by 10.52.69.232 with SMTP id h8mr16448345vdu.26.1360843062269; Thu, 14 Feb 2013 03:57:42 -0800 (PST) Received: by 10.58.210.3 with HTTP; Thu, 14 Feb 2013 03:57:42 -0800 (PST) In-Reply-To: References: <1360808084-9128-1-git-send-email-festevam@gmail.com> Date: Thu, 14 Feb 2013 09:57:42 -0200 Message-ID: Subject: Re: [PATCH] mmc: core: Fix start_signal_voltage_switch argument type From: Fabio Estevam To: Ulf Hansson Cc: cjb@laptop.org, kliu5@marvell.com, linux-mmc@vger.kernel.org, Fabio Estevam Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Ulf, On Thu, Feb 14, 2013 at 8:33 AM, Ulf Hansson wrote: > No. Fixup shall be done in SDHCI instead. Otherwise other host drivers > will break instead. Do you mean like this? int ret; @@ -1689,7 +1689,7 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); - switch (signal_voltage) { + switch (ios->signal_voltage) { case MMC_SIGNAL_VOLTAGE_330: /* Set 1.8V Signal Enable in the Host Control2 register to 0 */ ctrl &= ~SDHCI_CTRL_VDD_180; @@ -1762,7 +1762,7 @@ static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, } static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, - int signal_voltage) + struct mmc_ios *ios) { struct sdhci_host *host = mmc_priv(mmc); int err; @@ -1770,7 +1770,7 @@ static int sdhci_start_signal_voltage_switch(struct mmc_host *mmc, if (host->version < SDHCI_SPEC_300) return 0; sdhci_runtime_pm_get(host); - err = sdhci_do_start_signal_voltage_switch(host, signal_voltage); + err = sdhci_do_start_signal_voltage_switch(host, ios); sdhci_runtime_pm_put(host); return err; } --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1675,7 +1675,7 @@ static void sdhci_enable_sdio_irq(struct mmc_host *mmc, int enable) } static int sdhci_do_start_signal_voltage_switch(struct sdhci_host *host, - int signal_voltage) + struct mmc_ios *ios) { u16 ctrl;