From patchwork Sun Jan 8 21:55:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9503645 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 97FA5601EB for ; Sun, 8 Jan 2017 22:12:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8663228416 for ; Sun, 8 Jan 2017 22:12:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7AE6328450; Sun, 8 Jan 2017 22:12:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FF4028416 for ; Sun, 8 Jan 2017 22:12:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030950AbdAHV4s (ORCPT ); Sun, 8 Jan 2017 16:56:48 -0500 Received: from mout.web.de ([212.227.17.12]:55508 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966964AbdAHV4C (ORCPT ); Sun, 8 Jan 2017 16:56:02 -0500 Received: from [192.168.1.2] ([78.49.9.136]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MLgZ5-1cQ4SC2Oe3-000qG9; Sun, 08 Jan 2017 22:55:35 +0100 Subject: [PATCH 8/8] mmc-core: Use kmalloc_array() in mmc_alloc_sg() To: linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Shawn Lin , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sun, 8 Jan 2017 22:55:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> X-Provags-ID: V03:K0:QRlaMV83lyhJNQedHoQzAVJH1Lzf8ESXccy+HmFuuO41pDHxOnY fe9noL5+43S0fAGLciSOqnvJK1mHX0SpO0k+u1b4WWIbt9DF12i+a6CTa2/7AGPMKwLLRzw MPFf/1oVai0sNvah0z2J8gU36Y6sM8mNKY1wbQT+VphKp0uEBJPOeDDQaeQtZj0TDZ3+X/y /i7U0nmZHvjj8w+NdjQLA== X-UI-Out-Filterresults: notjunk:1; V01:K0:hLw2gh5tcxw=:QvMaCF6qQ+zAze5jZsz4PJ xkfCNorkLBgw3k8coD3OI2xTxgZxfKd+GSTMAPiBeAUasX5tmRZfGTtAHrwlIdbQH/hKi9oIv gLhHVNPvADzB6gHohVorzR0dp74R0VvHenyx2XPghrmY/J4z0MFs9L9GOGoJjSxIlZaUDmRso e4DGOW5Zf71JTtyVBzDpunkOxkkhXLBzjY+JpK5cpPtBZsIRwiMZBnGbnp0wNczmreDAteKFp +uyYMTB/me3+nTb7zuJPaQEHqgnBaxSGptAWa3yBLcg5rikBX4a7obXj5JLEdRxDgX6CCuGPQ LA29xUDiuRpTYoTHEEm9PbHf4yU90zbK2Y1jwGJDMpDw7JMmM0+dfW4NCcT/ITcDld8q7rKqB zWX+5txzJS77dV2sRqwVQHKvkbBTuCfUSmhE39IAoOrV9562eE0QS/s1qEEN2EQgl7q02mOeG e23xdKZzmxh+07vlh33kVvMYbPxe3KWLZy74ne1451s+W42eG9sy6AbosBMOc74mpkrhMzmkc odyNayQbk/TyqHPJTRoWfGImvM7PKTqcaInDOpZ7UAccxN9kYDYPncQHIwyvB73pe4oVIrp92 UJ6jeZp2jUN49mZEi8qWbOvbjmspB5rtbG9lsETBuYzU6Q3H8GiuAL45PNlMuF6TiPcqT7csA XiqtfWuDtb2hOOPsVOj95THMtbcVMS1W3SrTLqoLzAxCLjqms4+sbePy1QpXmVB3tadfqSP8w oF2LyDAwawC4RR6quYMD7kIo26RY451x2fDzAWjLYAaMgIllNBnhci2PLVSDoFE9zWRSl1Xvn 0q+kYb2 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sun, 8 Jan 2017 22:10:40 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring Reviewed-by: Linus Walleij Reviewed-by: Shawn Lin --- drivers/mmc/core/queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c index a6496d8027bc..b1986622c60e 100644 --- a/drivers/mmc/core/queue.c +++ b/drivers/mmc/core/queue.c @@ -152,7 +152,7 @@ static struct scatterlist *mmc_alloc_sg(int sg_len, int *err) { struct scatterlist *sg; - sg = kmalloc(sizeof(struct scatterlist)*sg_len, GFP_KERNEL); + sg = kmalloc_array(sg_len, sizeof(*sg), GFP_KERNEL); if (!sg) *err = -ENOMEM; else {