From patchwork Wed Nov 23 12:31:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jaehoon Chung X-Patchwork-Id: 9443097 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 471976075F for ; Wed, 23 Nov 2016 12:31:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D89E20499 for ; Wed, 23 Nov 2016 12:31:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2ED6325D99; Wed, 23 Nov 2016 12:31:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EF7720499 for ; Wed, 23 Nov 2016 12:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934415AbcKWMb0 (ORCPT ); Wed, 23 Nov 2016 07:31:26 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:49154 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933392AbcKWMbZ (ORCPT ); Wed, 23 Nov 2016 07:31:25 -0500 Received: from epcpsbgm2new.samsung.com (epcpsbgm2 [203.254.230.27]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OH300FMQHGAAZ80@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Wed, 23 Nov 2016 21:31:22 +0900 (KST) X-AuditID: cbfee61b-f796f6d000004092-45-58358c1a5fad Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 5B.5E.16530.A1C85385; Wed, 23 Nov 2016 21:31:22 +0900 (KST) Received: from [10.113.62.216] by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OH300IE2HGATKA0@mmp1.samsung.com>; Wed, 23 Nov 2016 21:31:22 +0900 (KST) Subject: Re: [GIT PULL] DWMMC controller for next To: Ulf Hansson References: <63a0b568-cd9e-d038-b7eb-08b7868f96f2@samsung.com> Cc: "linux-mmc@vger.kernel.org" From: Jaehoon Chung Message-id: Date: Wed, 23 Nov 2016 21:31:23 +0900 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e+xgK5Uj2mEwbcJVhZH/vczWhxfG+7A 5HHn2h42j8+b5AKYotxsMlITU1KLFFLzkvNTMvPSbZVCQ9x0LZQU8hJzU22VInR9Q4KUFMoS c0qBPCMDNODgHOAerKRvl+CWcerNFKaC/coV+689ZmlgbJDpYuTkkBAwkZi84T0LhC0mceHe erYuRi4OIYGljBKHlu1ghnAeMErsevmGGaRKWMBQ4snRF+wgtoiAhsSeh+dZIYquMknsOzAZ bBSzgLVE890zbCA2m4COxPZvx5lAbF4BO4nOiZPAmlkEVCXa3xwEGsrBISoQJvG80QmiRFDi x+R7YGM4Bewllu+cxwhSwiygLjFlSi7EdHmJzWveMk9gFJiFpGMWQtUsJFULGJlXMUqkFiQX FCel5xrlpZbrFSfmFpfmpesl5+duYgTHwzPpHYyHd7kfYhTgYFTi4dXYYhIhxJpYVlyZe4hR goNZSYR3ZpdphBBvSmJlVWpRfnxRaU5q8SFGU6AvJjJLiSbnA2M1ryTe0MTcxNzYwMLc0tLE SEmct3H2s3AhgfTEktTs1NSC1CKYPiYOTqkGxmpbIfdw9j/J6Vcb2Yv4Uk9z+We8ObZvwXyP o8dnJl/crXxmvWJx+ss2izOOG3R/iN54Z80scjiM8SD7/8rCI6nv3py75/1v/rPzSgk533Mm Mq1KmrncykzbT6oyjyWt0f9oyp+fi2/9ucC55CffzC2KhfJZGQwVl88fWHlxj9ExroVrb1ey 7VViKc5INNRiLipOBABURb8MnQIAAA== X-MTR: 20000000000000000@CPGS Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/23/2016 08:50 PM, Jaehoon Chung wrote: > On 11/23/2016 08:47 PM, Ulf Hansson wrote: >> On 22 November 2016 at 17:13, Ulf Hansson wrote: >>> On 22 November 2016 at 10:59, Jaehoon Chung wrote: >>>> Dear Ulf, >>>> >>>> Could you pull these patches on your next branch? >>>> If there is a problem, let me know, plz. >>>> >>>> The following changes since commit e2081b37d910c5e6c6925d9b4d0a7a6283f84ec5: >>>> >>>> Merge branch 'fixes' into next (2016-11-21 11:09:18 +0100) >>>> >>>> are available in the git repository at: >>>> >>>> https://github.com/jh80chung/dw-mmc.git for-ulf >>>> >>>> for you to fetch changes up to e25fd245b557482a8e0f7ab87841085f30706f3a: >>>> >>>> Documentation: synopsys-dw-mshc: remove the unused properties (2016-11-22 10:34:05 +0900) >>>> >>>> ---------------------------------------------------------------- >>>> Colin Ian King (1): >>>> mmc: dw_mmc: fix spelling mistake in dev_dbg message >>>> >>>> Jaehoon Chung (9): >>>> mmc: dw_mmc: display the real register value on debugfs >>>> mmc: dw_mmc: fix the debug message for checking card's present >>>> mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K >>>> mmc: dw_mmc: use the hold register when send stop command >>>> mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default >>>> mmc: dw_mmc: use the cookie's enum values for post/pre_req() >>>> mmc: dw_mmc: remove the unnecessary mmc_data structure >>>> mmc: dw_mmc: The "clock-freq-min-max" property was deprecated >>>> Documentation: synopsys-dw-mshc: remove the unused properties >>>> >>>> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 8 ++------ >>>> drivers/mmc/host/dw_mmc.c | 92 ++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------ >>>> include/linux/mmc/dw_mmc.h | 6 ++++++ >>>> 3 files changed, 52 insertions(+), 54 deletions(-) >>>> >>>> Best Regards, >>>> Jaehoon Chung >>> >>> Dear Jaehoon, thanks for the pull request. I have add queued it all up >>> for my next branch! >>> >>> >>> Kind regards >>> Uffe >> >> Jaehoon, >> >> It seems like some of these patches breaks Exynos 5250-arndale. Can >> you please have a look and see what you think? >> https://kernelci.org/boot/all/job/ulfh/kernel/v4.9-rc5-78-g52eb5d4531e4/ > > I will check and reply. Thanks for noticing. Ulf, I'm not sure but if more stable than now..i think that needs to check NULL pointer. What do you want how i do? Send patch or revert commit? I didn't have the 5250-arndale..so i can't test..How about the below? Best Regards, Jaehoon Chung > > Beset Regards, > Jaehoon Chung > >> >> Kind regards >> Uffe >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> >> >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 881ca3e..7a0cb97 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -167,12 +167,14 @@ static int dw_mci_regs_show(struct seq_file *s, void *v) { struct dw_mci *host = s->private; - seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); - seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); - seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); - seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); - seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); - seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); + if (host->regs) { + seq_printf(s, "STATUS:\t0x%08x\n", mci_readl(host, STATUS)); + seq_printf(s, "RINTSTS:\t0x%08x\n", mci_readl(host, RINTSTS)); + seq_printf(s, "CMD:\t0x%08x\n", mci_readl(host, CMD)); + seq_printf(s, "CTRL:\t0x%08x\n", mci_readl(host, CTRL)); + seq_printf(s, "INTMASK:\t0x%08x\n", mci_readl(host, INTMASK)); + seq_printf(s, "CLKENA:\t0x%08x\n", mci_readl(host, CLKENA)); + } return 0; }