From patchwork Sat Feb 26 01:26:45 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Paul Walmsley <paul@pwsan.com>
X-Patchwork-Id: 591871
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p1Q1Qnat026122
	for <patchwork-linux-mmc@patchwork.kernel.org>;
	Sat, 26 Feb 2011 01:26:49 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750785Ab1BZB0r (ORCPT
	<rfc822;patchwork-linux-mmc@patchwork.kernel.org>);
	Fri, 25 Feb 2011 20:26:47 -0500
Received: from utopia.booyaka.com ([72.9.107.138]:60158 "EHLO
	utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750725Ab1BZB0q (ORCPT
	<rfc822; linux-mmc@vger.kernel.org>); Fri, 25 Feb 2011 20:26:46 -0500
Received: (qmail 13469 invoked by uid 1019); 26 Feb 2011 01:26:45 -0000
Date: Fri, 25 Feb 2011 18:26:45 -0700 (MST)
From: Paul Walmsley <paul@pwsan.com>
To: linux-mmc@vger.kernel.org, cjb@laptop.org
cc: "Chikkature Rajashekar, Madhusudhan" <madhu.cr@ti.com>,
	Adrian Hunter <adrian.hunter@nokia.com>,
	Kishore Kadiyala <kishore.kadiyala@ti.com>,
	Tero Kristo <Tero.Kristo@nokia.com>, linux-omap@vger.kernel.org
Subject: Re: [PATCH] MMC: omap_hsmmc: enable interface clock before calling
	mmc_host_enable()
In-Reply-To: <AANLkTikMerO+FFsCJkiX7xa5m51zmKhQbikHDxT8GPK8@mail.gmail.com>
Message-ID: <alpine.DEB.2.00.1102251823540.6198@utopia.booyaka.com>
References: <alpine.DEB.2.00.1012071624270.13430@utopia.booyaka.com>
	<AANLkTikMerO+FFsCJkiX7xa5m51zmKhQbikHDxT8GPK8@mail.gmail.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Sender: linux-mmc-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-mmc.vger.kernel.org>
X-Mailing-List: linux-mmc@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]);
	Sat, 26 Feb 2011 01:26:50 +0000 (UTC)


diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 078fdf1..0cf0d89 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -2101,14 +2101,14 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
 	/* we start off in DISABLED state */
 	host->dpm_state = DISABLED;
 
-	if (mmc_host_enable(host->mmc) != 0) {
+	if (clk_enable(host->iclk) != 0) {
 		clk_put(host->iclk);
 		clk_put(host->fclk);
 		goto err1;
 	}
 
-	if (clk_enable(host->iclk) != 0) {
-		mmc_host_disable(host->mmc);
+	if (mmc_host_enable(host->mmc) != 0) {
+		clk_disable(host->iclk);
 		clk_put(host->iclk);
 		clk_put(host->fclk);
 		goto err1;