diff mbox series

mmc: block: fix memdup.cocci warnings

Message ID alpine.DEB.2.22.394.2008091720080.2450@hadrien (mailing list archive)
State New, archived
Headers show
Series mmc: block: fix memdup.cocci warnings | expand

Commit Message

Julia Lawall Aug. 9, 2020, 3:21 p.m. UTC 
From: kernel test robot <lkp@intel.com>

 Use kmemdup rather than duplicating its implementation

Generated by: scripts/coccinelle/api/memdup.cocci

Fixes: 68083eebfb0a ("mmc: block: register RPMB partition with the RPMB subsystem")
CC: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/intel/linux-intel-lts.git 5.4/preempt-rt
head:   64f494c08613ebb24a83b69223e7f90e8b7ce956
commit: 68083eebfb0a008e9bec30cefb2260f0543ed5ec [97/9103] mmc: block: register RPMB partition with the RPMB subsystem
:::::: branch date: 4 days ago
:::::: commit date: 9 months ago

 block.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff mbox series

Patch

--- a/drivers/mmc/core/block.c
+++ b/drivers/mmc/core/block.c
@@ -1270,11 +1270,10 @@  static int mmc_blk_rpmb_set_dev_id(struc
 {
 	char *id;

-	id = kmalloc(sizeof(card->raw_cid), GFP_KERNEL);
+	id = kmemdup(card->raw_cid, sizeof(card->raw_cid), GFP_KERNEL);
 	if (!id)
 		return -ENOMEM;

-	memcpy(id, card->raw_cid, sizeof(card->raw_cid));
 	ops->dev_id = id;
 	ops->dev_id_len = sizeof(card->raw_cid);