From patchwork Thu Jul 28 18:55:27 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?TWljaGHFgiBNaXJvc8WCYXc=?= X-Patchwork-Id: 1017542 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6SIqb9L021040 for ; Thu, 28 Jul 2011 18:55:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314Ab1G1Sz3 (ORCPT ); Thu, 28 Jul 2011 14:55:29 -0400 Received: from rere.qmqm.pl ([89.167.52.164]:57225 "EHLO rere.qmqm.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755249Ab1G1Sz2 (ORCPT ); Thu, 28 Jul 2011 14:55:28 -0400 Received: by rere.qmqm.pl (Postfix, from userid 1000) id 5904113A6A; Thu, 28 Jul 2011 20:55:27 +0200 (CEST) Message-Id: In-Reply-To: <20110728183319.GC24120@rere.qmqm.pl> From: =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= Subject: [PATCH] cb710: fix possible pci_dev leak in cb710_pci_configure() MIME-Version: 1.0 To: linux-mmc@vger.kernel.org, Chris Ball Cc: kernel-janitors@vger.kernel.org, Julia Lawall Date: Thu, 28 Jul 2011 20:55:27 +0200 (CEST) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 28 Jul 2011 18:55:30 +0000 (UTC) Reported-by: Julia Lawall Signed-off-by: Micha? Miros?aw --- drivers/misc/cb710/core.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c index efec413..68cd05b 100644 --- a/drivers/misc/cb710/core.c +++ b/drivers/misc/cb710/core.c @@ -33,7 +33,7 @@ EXPORT_SYMBOL_GPL(cb710_pci_update_config_reg); static int __devinit cb710_pci_configure(struct pci_dev *pdev) { unsigned int devfn = PCI_DEVFN(PCI_SLOT(pdev->devfn), 0); - struct pci_dev *pdev0 = pci_get_slot(pdev->bus, devfn); + struct pci_dev *pdev0; u32 val; cb710_pci_update_config_reg(pdev, 0x48, @@ -43,6 +43,7 @@ static int __devinit cb710_pci_configure(struct pci_dev *pdev) if (val & 0x80000000) return 0; + pdev0 = pci_get_slot(pdev->bus, devfn); if (!pdev0) return -ENODEV;