| Message ID | d8fc48bacf7cc153d806e10bc39ab507534f4691.1510997223.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18-11-17, 15:03, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > > drivers/mmc/host/sdhci-spear.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 8c0f884..900838b 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) > host->hw_name = "sdhci"; > host->ops = &sdhci_pltfm_ops; > host->irq = platform_get_irq(pdev, 0); > + if (host->irq <= 0) { > + ret = host->irq; > + goto err_host; > + } > host->quirks = SDHCI_QUIRK_BROKEN_ADMA; > > sdhci = sdhci_priv(host); Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Hi viresh, Could you please acknowledge a latest version(v3) of this patch. Thanks, On Monday 20 November 2017 11:14 AM, Viresh Kumar wrote: > On 18-11-17, 15:03, Arvind Yadav wrote: >> platform_get_irq() can fail here and we must check its return value. >> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> >> --- >> changes in v2 : >> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. >> >> drivers/mmc/host/sdhci-spear.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c >> index 8c0f884..900838b 100644 >> --- a/drivers/mmc/host/sdhci-spear.c >> +++ b/drivers/mmc/host/sdhci-spear.c >> @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) >> host->hw_name = "sdhci"; >> host->ops = &sdhci_pltfm_ops; >> host->irq = platform_get_irq(pdev, 0); >> + if (host->irq <= 0) { >> + ret = host->irq; >> + goto err_host; >> + } >> host->quirks = SDHCI_QUIRK_BROKEN_ADMA; >> >> sdhci = sdhci_priv(host); > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 8c0f884..900838b 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -82,6 +82,10 @@ static int sdhci_probe(struct platform_device *pdev) host->hw_name = "sdhci"; host->ops = &sdhci_pltfm_ops; host->irq = platform_get_irq(pdev, 0); + if (host->irq <= 0) { + ret = host->irq; + goto err_host; + } host->quirks = SDHCI_QUIRK_BROKEN_ADMA; sdhci = sdhci_priv(host);
platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/mmc/host/sdhci-spear.c | 4 ++++ 1 file changed, 4 insertions(+)