From patchwork Tue Sep 18 03:50:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Ball X-Patchwork-Id: 1470391 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D78CC3FCFC for ; Tue, 18 Sep 2012 03:51:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932657Ab2IRDu4 (ORCPT ); Mon, 17 Sep 2012 23:50:56 -0400 Received: from void.printf.net ([89.145.121.20]:42395 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932395Ab2IRDuz (ORCPT ); Mon, 17 Sep 2012 23:50:55 -0400 Received: from 173-166-109-250-newengland.hfc.comcastbusiness.net ([173.166.109.250] helo=pullcord.laptop.org) by void.printf.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1TDopY-0000xP-Bz; Tue, 18 Sep 2012 04:50:36 +0100 From: Chris Ball To: Thomas Abraham Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, ben-linux@fluff.org, wmb@firmworks.com, patches@linaro.org, Jaehoon Chung Subject: Re: [PATCH v5] mmc: sdhci-s3c: Add device tree support References: <1345741809-18599-1-git-send-email-thomas.abraham@linaro.org> Date: Mon, 17 Sep 2012 23:50:54 -0400 In-Reply-To: (Thomas Abraham's message of "Tue, 18 Sep 2012 07:15:22 +0530") Message-ID: User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.1.90 (gnu/linux) MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi, On Mon, Sep 17 2012, Thomas Abraham wrote: > On 23 August 2012 22:40, Thomas Abraham wrote: >> Add device tree based discovery support for Samsung's sdhci controller >> >> Cc: Ben Dooks >> Cc: Kukjin Kim >> Cc: Chris Ball >> Signed-off-by: Thomas Abraham >> --- >> Changes since v4: >> Adapted to new mmc core card detection bindings as specfied in the patch: >> [PATCH] mmc: dt: Add card-detection properties to core binding >> and extends it "samsung,cd-pinmux-gpio" property as suggested by >> Mitch Bradley >> >> Changes since v3: >> >> The patch series that adds device tree support for Samsung sdhci controller >> had six patches in total, of which, the first five patches have been accepted. >> The sixth patch in the series was dropped since it was using custom Samsung >> properties for descrbing the bus-width and card-detect gpio, but had otherwise >> addressed all the comments. >> >> This patch reworks the sixth patch in v3 of the sdhci device tree support >> patch series. The only change in this patch from the v3 version is the use of >> generic mmc bindings for descrbing the bus-width and card-detect gpio. >> >> .../devicetree/bindings/mmc/samsung-sdhci.txt | 53 +++++++ >> drivers/mmc/host/sdhci-s3c.c | 162 +++++++++++++++++++- >> 2 files changed, 209 insertions(+), 6 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/mmc/samsung-sdhci.txt > > Hi Chris, > > This patch adds device tree support for sdhci-s3c driver. All the > comments for this patch has been addressed. Can this be queued for > v3.7? Yes, sounds good. Jaehoon, perhaps you could give your Reviewed-by for me to add to the patch? I've pushed this to mmc-next for 3.7 now, after adding Jaehoon's else-if suggestion that wasn't acted on: Thanks, - Chris. Reviewed-by: Jaehoon Chung diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c index 3d91c7a..0c77b10 100644 --- a/drivers/mmc/host/sdhci-s3c.c +++ b/drivers/mmc/host/sdhci-s3c.c @@ -461,22 +461,18 @@ static int __devinit sdhci_s3c_parse_dt(struct device *dev, if (gpio_is_valid(gpio)) { pdata->cd_type = S3C_SDHCI_CD_GPIO; goto found_cd; - } else { - if (gpio != -ENOENT) { - dev_err(dev, "invalid card detect gpio specified\n"); - return -EINVAL; - } + } else if (gpio != -ENOENT) { + dev_err(dev, "invalid card detect gpio specified\n"); + return -EINVAL; } gpio = of_get_named_gpio(node, "samsung,cd-pinmux-gpio", 0); if (gpio_is_valid(gpio)) { pdata->cd_type = S3C_SDHCI_CD_INTERNAL; goto found_cd; - } else { - if (gpio != -ENOENT) { - dev_err(dev, "invalid card detect gpio specified\n"); - return -EINVAL; - } + } else if (gpio != -ENOENT) { + dev_err(dev, "invalid card detect gpio specified\n"); + return -EINVAL; } dev_info(dev, "assuming no card detect line available\n");