From patchwork Sun Jan 30 21:32:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Tomlin X-Patchwork-Id: 12730166 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 110BCC433F5 for ; Sun, 30 Jan 2022 21:32:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356511AbiA3VcZ (ORCPT ); Sun, 30 Jan 2022 16:32:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35352 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233152AbiA3VcT (ORCPT ); Sun, 30 Jan 2022 16:32:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643578339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=XH3FS3zqUJ/BeN7fcnEtazpeIRBO/BWDiirv0AZyDOI=; b=P2gZ6wObpfU1zJ8FGLdMONJ3wAhsN/c/iKkCmSV8BLohhbDnc0rqkSP7JMKhXGoe4T9+Bz H1hdbMngdrTXO9yw9te1xPe9y730RBo/tdXAlzIm06IB90ifHq0w5Ge7a/hwjOlzrJTOK9 YHUUUGg3UtEwQdmR5HdazD+U3nqzZ0E= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-494-6KL2nNt4MAiXBGVlsi8Apg-1; Sun, 30 Jan 2022 16:32:17 -0500 X-MC-Unique: 6KL2nNt4MAiXBGVlsi8Apg-1 Received: by mail-wm1-f72.google.com with SMTP id n7-20020a1c7207000000b0034ec3d8ce0aso5135190wmc.8 for ; Sun, 30 Jan 2022 13:32:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XH3FS3zqUJ/BeN7fcnEtazpeIRBO/BWDiirv0AZyDOI=; b=78XkUK6Wf384FvWypXomB7j/R1KN2bE4opUb7sfxjZw9fxcvuN+DmubTL0/hTP1vNI z7IMvAtZzfylKb0LKkUJqAdEyGoKWb58uUtc6G8vuzwgooSX8inRzxtgiX79DZJWZgD2 WEggmvzpnuRw2DXvUg7Q4C4iTKpTPEtFblXxASoHhESVNV88eMw+SCwym977UO2PMD8a 8KICT8S4bn+VP/ezm3zUqDA3TV6UUbDycYQPSGtzB8859jz9vnoEEpxNqkYQ2FPSn8RE MJdMaqrFcNtZeHUDoCNRCHB5XMZTCsQ5aBt87nQ56AFcAX31Cj/AiRq6ZH54GfmtTj8r Oxnw== X-Gm-Message-State: AOAM532dsGB6OC+CTjThNQS3BCtAavPYeUP4KvAkC68PQMhM+mk2RXv3 9j8/M8hdmDc7DLPsO3Cti7UiByum2Rj8+5T+P4IT6kNegX6imUnmSHzSMjnAZKOxSCUnWvQhaDZ 3GeYhGeaP7qZQAzqBRxbx8bMM X-Received: by 2002:a5d:4f08:: with SMTP id c8mr15236191wru.710.1643578336556; Sun, 30 Jan 2022 13:32:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwycUbzQ0ojm8DSjf9yHn53arqjXwbEXsMvB8ev+BAuA51PaSpRIEuPd+rwaGFX9lfQxZVu2A== X-Received: by 2002:a5d:4f08:: with SMTP id c8mr15236178wru.710.1643578336371; Sun, 30 Jan 2022 13:32:16 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id n14sm10355106wri.75.2022.01.30.13.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jan 2022 13:32:15 -0800 (PST) From: Aaron Tomlin To: mcgrof@kernel.org Cc: cl@linux.com, pmladek@suse.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, live-patching@vger.kernel.org, atomlin@atomlin.com, ghalat@redhat.com, allen.lkml@gmail.com, void@manifault.com, joe@perches.com Subject: [RFC PATCH v4 00/13] module: core code clean up Date: Sun, 30 Jan 2022 21:32:01 +0000 Message-Id: <20220130213214.1042497-1-atomlin@redhat.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: Hi Luis, As per your suggestion [1], this is an attempt to refactor and split optional code out of core module support code into separate components. This version is based on branch mcgrof/modules-next since a97ac8cb24a3/or modules-5.17-rc1. Please let me know your thoughts. Changes since v1 [2]: - Moved module version support code into a new file Changes since v2 [3]: - Moved module decompress support to a separate file - Made check_modinfo_livepatch() generic (Petr Mladek) - Removed filename from each newly created file (Luis Chamberlain) - Addressed some (i.e. --ignore=ASSIGN_IN_IF,AVOID_BUG was used) minor scripts/checkpatch.pl concerns e.g., use strscpy over strlcpy and missing a blank line after declarations (Allen) Changes since v3 [4]: - Refactored both is_livepatch_module() and set_livepatch_module(), respectively, to use IS_ENABLED(CONFIG_LIVEPATCH) (Joe Perches) - Addressed various compiler warnings e.g., no previous prototype (0-day) [1]: https://lore.kernel.org/lkml/YbEZ4HgSYQEPuRmS@bombadil.infradead.org/ [2]: https://lore.kernel.org/lkml/20211228213041.1356334-1-atomlin@redhat.com/ [3]: https://lore.kernel.org/lkml/20220106234319.2067842-1-atomlin@redhat.com/ [4]: https://lore.kernel.org/lkml/20220128203934.600247-1-atomlin@redhat.com/ Aaron Tomlin (13): module: Move all into module/ module: Simple refactor in preparation for split module: Move livepatch support to a separate file module: Move latched RB-tree support to a separate file module: Move arch strict rwx support to a separate file module: Move strict rwx support to a separate file module: Move extra signature support out of core code module: Move kmemleak support to a separate file module: Move kallsyms support into a separate file module: Move procfs support into a separate file module: Move sysfs support into a separate file module: Move kdb_modules list out of core code module: Move version support into a separate file MAINTAINERS | 2 +- include/linux/module.h | 64 +- kernel/Makefile | 5 +- kernel/debug/kdb/kdb_main.c | 5 + kernel/module-internal.h | 50 - kernel/module/Makefile | 20 + kernel/module/arch_strict_rwx.c | 44 + kernel/module/debug_kmemleak.c | 30 + .../decompress.c} | 2 +- kernel/module/internal.h | 236 +++ kernel/module/kallsyms.c | 502 +++++ kernel/module/livepatch.c | 74 + kernel/{module.c => module/main.c} | 1874 +---------------- kernel/module/procfs.c | 142 ++ .../signature.c} | 0 kernel/module/signing.c | 120 ++ kernel/module/strict_rwx.c | 83 + kernel/module/sysfs.c | 425 ++++ kernel/module/tree_lookup.c | 109 + kernel/module/version.c | 110 + kernel/module_signing.c | 45 - 21 files changed, 2038 insertions(+), 1904 deletions(-) delete mode 100644 kernel/module-internal.h create mode 100644 kernel/module/Makefile create mode 100644 kernel/module/arch_strict_rwx.c create mode 100644 kernel/module/debug_kmemleak.c rename kernel/{module_decompress.c => module/decompress.c} (99%) create mode 100644 kernel/module/internal.h create mode 100644 kernel/module/kallsyms.c create mode 100644 kernel/module/livepatch.c rename kernel/{module.c => module/main.c} (63%) create mode 100644 kernel/module/procfs.c rename kernel/{module_signature.c => module/signature.c} (100%) create mode 100644 kernel/module/signing.c create mode 100644 kernel/module/strict_rwx.c create mode 100644 kernel/module/sysfs.c create mode 100644 kernel/module/tree_lookup.c create mode 100644 kernel/module/version.c delete mode 100644 kernel/module_signing.c base-commit: a97ac8cb24a3c3ad74794adb83717ef1605d1b47