From patchwork Sat Nov 18 02:54:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Maurer X-Patchwork-Id: 13459828 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tuNl5Lb5" Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F744D7A for ; Fri, 17 Nov 2023 18:58:07 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-da1aa98ec19so3186710276.2 for ; Fri, 17 Nov 2023 18:58:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700276286; x=1700881086; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=QcqINJQ5diQHGOPsun01LVrGFl32Nw5/hV5eaRRLRg8=; b=tuNl5Lb5paQT0f052qeluQ+0tAGSdmaA/l4/8oASX0hOCpYfkhl30eZ7b/IQL0wQQl zXSOKlZy8pE3mjni/S0A1F5EC95HJ4exsuFi76fQR9wU8gCyEANaDN1uJCGtM+CVSacm Z8q6Hbo9ARDcAp+A/s/EunkKfcR2wB4oySt8s1gG2LUiDe+FKWGoZdaDO5ZQOXug2G9q AW5U9X6Kq5bYFCfDjkmoZuI2Eyj1kbJKSy2gL1Js6nep5EbeGxQRfDz4tA8gHABKUNhX bQu3MYQ0gPMUWFcNMtBdWx5FJM4FfstCMUkGb2jOaGTqGJs25RCPBbK4R9z0+K6CP2EN wAUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700276286; x=1700881086; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=QcqINJQ5diQHGOPsun01LVrGFl32Nw5/hV5eaRRLRg8=; b=sNHUUnPoA6W1uSlfwSphJB0MlRAX6LKSt6wqVAT+kEu/xlxYtgLNa2erJqx3DWFmAR ztwDdY1OvzK7Ie2HeNvzu6a5ecU21Hl6e6VX5PhnDFq0OzNLvG9OPMGFq2Nl9sJz6acV 0HDbzmxEIM/putpvdgXaShnltVo+rnBSA84iUnRGfkGG9lFH2m94od7qp2ZUgPbRJekU 1XZtVyOB4wkkRbc2FQmqMakcjWghsP3h1TeOfDdAiyPPd9g253LE4p0nhiocKHHWK3Jv tkdNh2Usva3aFfYXXQOMzkEWp/VT2YLNTeTAiu8CWGJfGTC3BmxGy5d3nedN+WNBVMUZ 0Ggg== X-Gm-Message-State: AOJu0YyzXsFtxI6u1pSDHcEgh0ZvkZUoP4DxkX714pD6aHC4G87L/bEG wiFBfKur6uhZuJrKCN+oB15HImo/gULj X-Google-Smtp-Source: AGHT+IEipLfYfNhkIRCz9BLTKi/Q07W5+qhbxpM56Qf4WuGm87G6Dh+mgTSQvuA9zn4iAz2ODTBXSWhTbmQj X-Received: from anyblade.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:1791]) (user=mmaurer job=sendgmr) by 2002:a25:abe3:0:b0:d9c:c9a8:8c27 with SMTP id v90-20020a25abe3000000b00d9cc9a88c27mr27045ybi.13.1700276286411; Fri, 17 Nov 2023 18:58:06 -0800 (PST) Date: Sat, 18 Nov 2023 02:54:41 +0000 Precedence: bulk X-Mailing-List: linux-modules@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.43.0.rc0.421.g78406f8d94-goog Message-ID: <20231118025748.2778044-1-mmaurer@google.com> Subject: [PATCH v2 0/5] MODVERSIONS + RUST Redux From: Matthew Maurer To: Masahiro Yamada , Nick Desaulniers , Miguel Ojeda , Gary Guo , Luis Chamberlain Cc: Nathan Chancellor , Nicolas Schier , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-kbuild@vger.kernel.org, rust-for-linux@vger.kernel.org, Laura Abbott , Matthew Maurer The goal of this patch series is to allow MODVERSIONS and RUST to be enabled simultaneously. The primary issue with doing this at the moment is that Rust uses some extremely long symbol names - for those unfamiliar with Rust, it may be helpful to think of some of the mangled C++ names you may have seen in binaries in the past. Previously, Gary Guo attempted to accomplish this by modifying the existing modversion format [1] to support variable-length symbol names. This was unfortunately considered to be a potential userspace break because kmod tools inspect this kernel module metadata. Masahiro Yamada suggested [2] that this could instead be done with a section per-field. This gives us the ability to be more flexible with this format in the future, as a new field or additional information will be in a new section which userspace tools will not yet attempt to read. In the previous version of this patchset, Luis Chamberlain suggested [3] I move validation out of the version checking and into the elf validity checker, and also add kernel-docs over there. I found elf_validity_cached_copy to be fairly dense and difficult to directly describe, so I refactored it into easier to explain pieces. In the process, I found a few missing checks and added those as well. See [PATCH 2/5] for more details. If this is too much, I'm more than happy to drop this patch from the series in favor of just adding the kernel-doc to the original code, but figured I'd offer it up in case the added clarity and checks were valuable. [1] https://lore.kernel.org/lkml/20230111161155.1349375-1-gary@garyguo.net/ [2] https://lore.kernel.org/lkml/CAK7LNATsuszFR7JB5ZkqVS1W=hWr9=E7bTf+MvgJ+NXT3aZNwg@mail.gmail.com/ [3] https://lore.kernel.org/lkml/ZVZNh%2FPA5HiVRkeb@bombadil.infradead.org/ Matthew Maurer (5): export_report: Rehabilitate script modules: Refactor + kdoc elf_validity_cached_copy modpost: Extended modversion support rust: Allow MODVERSIONS export_report: Use new version info format arch/powerpc/kernel/module_64.c | 25 +- init/Kconfig | 1 - kernel/module/internal.h | 18 +- kernel/module/main.c | 663 +++++++++++++++++++++++++------- kernel/module/version.c | 43 +++ scripts/export_report.pl | 17 +- scripts/mod/modpost.c | 37 +- 7 files changed, 642 insertions(+), 162 deletions(-)