diff mbox series

[v3,1/3] depmod: prevent module dependency files missing during depmod invocation.

Message ID 20181217224629.22687-2-msuchanek@suse.de (mailing list archive)
State New, archived
Headers show
Series Fix dependency file corruption with parallel depmod invocation | expand

Commit Message

Michal Suchánek Dec. 17, 2018, 10:46 p.m. UTC
Depmod deletes the module dependency files before moving the temporary
files in their place. This results in user seeing no dependency files
while they are updated. Remove the unlink call. The rename call should
suffice to move the new file in place and unlink the old one. It should
also do both atomically so there is no window when no dependency file

Signed-off-by: Michal Suchanek <msuchanek@suse.de>
 tools/depmod.c | 1 -
 1 file changed, 1 deletion(-)
diff mbox series


diff --git a/tools/depmod.c b/tools/depmod.c
index 989d9077926c..18c0d61b2db3 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2451,7 +2451,6 @@  static int depmod_output(struct depmod *depmod, FILE *out)
-		unlinkat(dfd, itr->name, 0);
 		if (renameat(dfd, tmp, dfd, itr->name) != 0) {
 			err = -errno;
 			CRIT("renameat(%s, %s, %s, %s): %m\n",