diff mbox series

[2/3] depmod: fix modules.builtin.alias.bin output

Message ID 20210511180615.400191-3-lucas.demarchi@intel.com (mailing list archive)
State New
Headers show
Series Fix modules.builtin.alias.bin creation | expand

Commit Message

Lucas De Marchi May 11, 2021, 6:06 p.m. UTC
Due to wrong documentation on kmod_module_get_info() we ended up
checking for 0 as return. Check for > 0 to decided if we want to write
the index to the file, otherwise we would output a 0-sized index on
success.
---
 tools/depmod.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/tools/depmod.c b/tools/depmod.c
index 170a1d8..eb810b8 100644
--- a/tools/depmod.c
+++ b/tools/depmod.c
@@ -2457,7 +2457,7 @@  static int output_builtin_alias_bin(struct depmod *depmod, FILE *out)
 
 out:
 	/* do not bother writing the index if we are going to discard it */
-	if (!ret)
+	if (ret > 0)
 		index_write(idx, out);
 
 	if (builtin)