[06/27] interconnect: remove MODULE_LICENSE in non-modules

Commit Message

Nick Alcock Feb. 24, 2023, 3:07 p.m. UTC

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[e-mail]>
Suggested-by: Luis Chamberlain <[e-mail]>
Cc: Luis Chamberlain <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: Hitomi Hasegawa <[e-mail]>
Cc: Georgi Djakov <[e-mail]>
Cc: [e-mail]
---
 drivers/interconnect/core.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Georgi Djakov March 15, 2023, 3:23 p.m. UTC | #1

Hi Nick,

Thanks for the patch!

On 24.02.23 17:07, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
> 
> So remove it in the files in this commit, none of which can be built as
> modules.

I think that it might be better to remove not just the MODULE_LICENCE,
but also the other module related code in this file.

Thanks,
Georgi

> 
> Signed-off-by: Nick Alcock <[e-mail]>
> Suggested-by: Luis Chamberlain <[e-mail]>
> Cc: Luis Chamberlain <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: Hitomi Hasegawa <[e-mail]>
> Cc: Georgi Djakov <[e-mail]>
> Cc: [e-mail]
> ---
>   drivers/interconnect/core.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 25debded65a8..de61a639fab4 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -1146,4 +1146,3 @@ device_initcall(icc_init);
>   
>   MODULE_AUTHOR("Georgi Djakov <[e-mail]>");
>   MODULE_DESCRIPTION("Interconnect Driver Core");
> -MODULE_LICENSE("GPL v2");

Patch

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 25debded65a8..de61a639fab4 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -1146,4 +1146,3 @@  device_initcall(icc_init);
 
 MODULE_AUTHOR("Georgi Djakov <[e-mail]>");
 MODULE_DESCRIPTION("Interconnect Driver Core");
-MODULE_LICENSE("GPL v2");