| Message ID | 20230228130215.289081-6-nick.alcock@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MODULE_LICENSE removals, fifth tranche | expand |
> -----Original Message----- > From: Nick Alcock <nick.alcock@oracle.com> > Sent: Tuesday, February 28, 2023 5:02 AM > To: mcgrof@kernel.org > Cc: linux-modules@vger.kernel.org; linux-kernel@vger.kernel.org; Hitomi > Hasegawa <hasegawa-hitomi@fujitsu.com>; Keller, Jacob E > <jacob.e.keller@intel.com> > Subject: [PATCH 05/20] lib: remove MODULE_LICENSE in non-modules > > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock <nick.alcock@oracle.com> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org> > Cc: Luis Chamberlain <mcgrof@kernel.org> > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> > Cc: Jacob Keller <jacob.e.keller@intel.com> Acked-by: Jacob Keller <jacob.e.keller@intel.com> > --- > lib/pldmfw/pldmfw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c > index 6e77eb6d8e72e..54e1809a38fd9 100644 > --- a/lib/pldmfw/pldmfw.c > +++ b/lib/pldmfw/pldmfw.c > @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const > struct firmware *fw) > EXPORT_SYMBOL(pldmfw_flash_image); > > MODULE_AUTHOR("Jacob Keller <jacob.e.keller@intel.com>"); > -MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("PLDM firmware flash update library"); > -- > 2.39.1.268.g9de2f9a303
diff --git a/lib/pldmfw/pldmfw.c b/lib/pldmfw/pldmfw.c index 6e77eb6d8e72e..54e1809a38fd9 100644 --- a/lib/pldmfw/pldmfw.c +++ b/lib/pldmfw/pldmfw.c @@ -875,5 +875,4 @@ int pldmfw_flash_image(struct pldmfw *context, const struct firmware *fw) EXPORT_SYMBOL(pldmfw_flash_image); MODULE_AUTHOR("Jacob Keller <jacob.e.keller@intel.com>"); -MODULE_LICENSE("GPL v2"); MODULE_DESCRIPTION("PLDM firmware flash update library");
Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their containing object file as a module when it is not (false positives), and modprobe might succeed rather than failing with a suitable error message. So remove it in the files in this commit, none of which can be built as modules. Signed-off-by: Nick Alcock <nick.alcock@oracle.com> Suggested-by: Luis Chamberlain <mcgrof@kernel.org> Cc: Luis Chamberlain <mcgrof@kernel.org> Cc: linux-modules@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com> Cc: Jacob Keller <jacob.e.keller@intel.com> --- lib/pldmfw/pldmfw.c | 1 - 1 file changed, 1 deletion(-)