| Message ID | 20230418-add-missing-kmod_module_unref_list-v1-1-ab5b554f15ee@avm.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | modprobe: rmmod_do_module: Free kmod list of holders | expand |
On Tue, 18 Apr 2023 10:52:38 +0200, Nicolas Schier wrote: > Add a missing kmod_module_unref_list() to fix a memory leak. > > Applied, thanks! [1/1] modprobe: rmmod_do_module: Free kmod list of holders commit: 116e7c7fc00e8565caf913399c38852975094a75 Best regards,
diff --git a/tools/modprobe.c b/tools/modprobe.c index 3b7897c..e891028 100644 --- a/tools/modprobe.c +++ b/tools/modprobe.c @@ -455,6 +455,7 @@ static int rmmod_do_module(struct kmod_module *mod, int flags) struct kmod_list *holders = kmod_module_get_holders(mod); err = rmmod_do_modlist(holders, true); + kmod_module_unref_list(holders); if (err < 0) goto error; }
Add a missing kmod_module_unref_list() to fix a memory leak. Fixes: 42b32d30c38e ("modprobe: Fix holders removal") Signed-off-by: Nicolas Schier <n.schier@avm.de> --- Resend as a separate patch as suggested in https://lore.kernel.org/linux-modules/20230412192151.jbbcltmcwwamhlm6@ldmartin-desk2.lan/ --- tools/modprobe.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 3d1bd339ab942ea47e60f053f4b11b0c47ff082b change-id: 20230418-add-missing-kmod_module_unref_list-e7c4dd5b6625 Best regards,