diff mbox series

module: Remove redundant TASK_UNINTERRUPTIBLE

Message ID 20231208082934.1969383-1-haokexin@gmail.com (mailing list archive)
State New
Headers show
Series module: Remove redundant TASK_UNINTERRUPTIBLE | expand

Commit Message

Kevin Hao Dec. 8, 2023, 8:29 a.m. UTC 
TASK_KILLABLE already includes TASK_UNINTERRUPTIBLE, so there is no
need to add a separate TASK_UNINTERRUPTIBLE.

Signed-off-by: Kevin Hao <haokexin@gmail.com>
---
 kernel/module/dups.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luis Chamberlain Dec. 19, 2023, 9:30 p.m. UTC | #1 
On Fri, Dec 08, 2023 at 04:29:34PM +0800, Kevin Hao wrote:
> TASK_KILLABLE already includes TASK_UNINTERRUPTIBLE, so there is no
> need to add a separate TASK_UNINTERRUPTIBLE.
> 
> Signed-off-by: Kevin Hao <haokexin@gmail.com>

Applied and pushed, thanks!

  Luis
diff mbox series

Patch

diff --git a/kernel/module/dups.c b/kernel/module/dups.c
index f3d7ea1e96d8..9a92f2f8c9d3 100644
--- a/kernel/module/dups.c
+++ b/kernel/module/dups.c
@@ -207,7 +207,7 @@  bool kmod_dup_request_exists_wait(char *module_name, bool wait, int *dup_ret)
 	 * optimization enabled ...
 	 */
 	ret = wait_for_completion_state(&kmod_req->first_req_done,
-					TASK_UNINTERRUPTIBLE | TASK_KILLABLE);
+					TASK_KILLABLE);
 	if (ret) {
 		*dup_ret = ret;
 		return true;