| Message ID | 20240719-abi-fixes-v1-2-1e6d99a2846b@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | libkmod: misc ABI changes | expand |
On Fri, Jul 19, 2024 at 05:12:42PM GMT, Emil Velikov via B4 Relay wrote: >From: Emil Velikov <emil.l.velikov@gmail.com> > >The symbol was introduced with v30, yet was erroneously added in the v5 >section. Move it to the correct place. > >In theory this might cause an issue - severity depends on how the >runtime linker is setup. From a harmless warning (on stderr/stdout) to >failure to load the library. > >In practise this shouldn't be a problem, since there are seemingly no >external users of the API. > >Fixes: 9becaae ("libkmod: Add lookup from module name") >Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com> >--- >I'm fairly confident this commit won't cause an issue, although auditing >the whole internet is not possible in practise. In my search I checked >through Google, Github and all Arch packages using libkmod, namely: > > - dracut > - igt-gpu-tools > - libblockdev > - ndctl > - open-scsi > - pciutils > - stress-ng > - systemd > >Another option is to make the symbol as internal, since it's used solely >by modinfo which static links libkmod. > >...we could also leave things as-is. I think it's better to handle this as an issue and let it propagate through distros. Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> thanks, Lucas De Marchi >--- > libkmod/libkmod.sym | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/libkmod/libkmod.sym b/libkmod/libkmod.sym >index 0d6d338..e71f488 100644 >--- a/libkmod/libkmod.sym >+++ b/libkmod/libkmod.sym >@@ -31,7 +31,6 @@ global: > kmod_module_new_from_name; > kmod_module_new_from_path; > kmod_module_new_from_lookup; >- kmod_module_new_from_name_lookup; > kmod_module_new_from_loaded; > kmod_module_ref; > kmod_module_unref; >@@ -94,3 +93,8 @@ LIBKMOD_22 { > global: > kmod_get_dirname; > } LIBKMOD_6; >+ >+LIBKMOD_30 { >+global: >+ kmod_module_new_from_name_lookup; >+} LIBKMOD_22; > >-- >2.45.2 > >
diff --git a/libkmod/libkmod.sym b/libkmod/libkmod.sym index 0d6d338..e71f488 100644 --- a/libkmod/libkmod.sym +++ b/libkmod/libkmod.sym @@ -31,7 +31,6 @@ global: kmod_module_new_from_name; kmod_module_new_from_path; kmod_module_new_from_lookup; - kmod_module_new_from_name_lookup; kmod_module_new_from_loaded; kmod_module_ref; kmod_module_unref; @@ -94,3 +93,8 @@ LIBKMOD_22 { global: kmod_get_dirname; } LIBKMOD_6; + +LIBKMOD_30 { +global: + kmod_module_new_from_name_lookup; +} LIBKMOD_22;