mbox series

[GIT,PULL] Modules fixes for v5.19-rc7

Message ID YsxkpIjGs7YwdIai@bombadil.infradead.org (mailing list archive)
State New, archived
Headers show
Series [GIT,PULL] Modules fixes for v5.19-rc7 | expand

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ tags/modules-5.19-rc7

Message

Luis Chamberlain July 11, 2022, 5:57 p.m. UTC
Linus,

here are some fixes for v5.17-rc7 which I've queued up since July 1st. Two
two critical fixes are the buffer overflow Fixed by Adrian Hunter due to a
possible incorrect length used, and a regression fix by Aaron Tomlin on
PREEMPT_RT=y as reported by Steven Rostedt since we're now starting to treat
PREEMPT_RT=y as a first class citizen.

Adrian Hunter's patch landed on my inbox July 1st on Friday right before
the long 4th of July holiday and the PREEMPT_RT=y fix just took some love
(until today to settle) on the commit log and hence the delay on these. I
don't foresee more fixes coming from the modules code move that was done
on v5.19-rc1.

In the future, for code moving around, we will want to ignore checkpatch
complaints as that may obfuscate code regressions, such as what happened
with the request to move from strlcpy() to using strscpy().

Other than Aaron's PREEMPT_RT=y, the rest of the code had gotten tested
through 0-day since July 2nd, but I only got to push all this to
linux-next today as I was waiting for Aaron's commit log adjustments
which finally settled today.

  Luis

The following changes since commit 1a0e93df1e107dc766fdf86ae88076efd9f376e6:

  Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma (2022-06-30 10:03:22 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ tags/modules-5.19-rc7

for you to fetch changes up to e69a66147d49506062cd837f3b230ee3e98102ab:

  module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT (2022-07-11 10:19:09 -0700)

----------------------------------------------------------------
modules-5.19-rc7

Although most of the move of code in in v5.19-rc1 should have not
introduced a regression patch review on one of the file changes captured
a checkpatch warning which advised to use strscpy() and it caused a
buffer overflow when an incorrect length is passed.

Another change which checkpatch complained about was an odd RCU usage,
but that was properly addressed in a separate patch to the move by Aaron.
That caused a regression with PREEMPT_RT=y due to an unbounded latency.

This series fixes both and adjusts documentation which we forgot to do
for the move.

----------------------------------------------------------------
Aaron Tomlin (1):
      module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT

Adrian Hunter (1):
      modules: Fix corruption of /proc/kallsyms

Christophe Leroy (2):
      module: Fix selfAssignment cppcheck warning
      module: Fix "warning: variable 'exit' set but not used"

Masahiro Yamada (1):
      doc: module: update file references

 Documentation/core-api/kernel-api.rst              |  2 +-
 Documentation/core-api/symbol-namespaces.rst       |  4 +--
 Documentation/livepatch/module-elf-format.rst      | 10 +++----
 .../it_IT/core-api/symbol-namespaces.rst           |  6 ++--
 .../translations/zh_CN/core-api/kernel-api.rst     |  2 +-
 .../zh_CN/core-api/symbol-namespaces.rst           |  2 +-
 kernel/module/internal.h                           | 13 ++++----
 kernel/module/kallsyms.c                           | 35 ++++++++++++++--------
 kernel/module/main.c                               |  9 +++---
 9 files changed, 48 insertions(+), 35 deletions(-)

Comments

pr-tracker-bot@kernel.org July 11, 2022, 8:02 p.m. UTC | #1
The pull request you sent on Mon, 11 Jul 2022 10:57:56 -0700:

> git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/ tags/modules-5.19-rc7

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/b5374396e5de0402822bce4945c886d2a2962a40

Thank you!