| Message ID | bb37ff26b0c748d0ca883d8f301190cd1177aad2.1667336095.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Tue, Nov 01, 2022 at 10:14:06PM +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> Luis
On Tue 2022-11-01 22:14 +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- > kernel/module/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/module/main.c b/kernel/module/main.c > index ff2dfd1f548d..79e17522e196 100644 > --- a/kernel/module/main.c > +++ b/kernel/module/main.c > @@ -17,6 +17,7 @@ > #include <linux/fs.h> > #include <linux/kernel.h> > #include <linux/kernel_read_file.h> > +#include <linux/kstrtox.h> > #include <linux/slab.h> > #include <linux/vmalloc.h> > #include <linux/elf.h> > @@ -2649,7 +2650,7 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname, > int ret; > > if (strcmp(param, "async_probe") == 0) { > - if (strtobool(val, &mod->async_probe_requested)) > + if (kstrtobool(val, &mod->async_probe_requested)) > mod->async_probe_requested = true; > return 0; > } > -- > 2.34.1 > Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
Le 02/11/2022 à 19:41, Luis Chamberlain a écrit : > On Tue, Nov 01, 2022 at 10:14:06PM +0100, Christophe JAILLET wrote: >> strtobool() is the same as kstrtobool(). >> However, the latter is more used within the kernel. >> >> In order to remove strtobool() and slightly simplify kstrtox.h, switch to >> the other function name. >> >> While at it, include the corresponding header file (<linux/kstrtox.h>) >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > > Reviewed-by: Luis Chamberlain <mcgrof@kernel.org> > > Luis > Hi, This has been R-b 2 months ago by 2 persons, and I've just resent patches in this serie that have neither been merged in -next, nor A-b or R-b. So for this one, it is just a polite reminder.
On Tue, Nov 01, 2022 at 10:14:06PM +0100, Christophe JAILLET wrote: > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- Queued up to modules-next. Luis
diff --git a/kernel/module/main.c b/kernel/module/main.c index ff2dfd1f548d..79e17522e196 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -17,6 +17,7 @@ #include <linux/fs.h> #include <linux/kernel.h> #include <linux/kernel_read_file.h> +#include <linux/kstrtox.h> #include <linux/slab.h> #include <linux/vmalloc.h> #include <linux/elf.h> @@ -2649,7 +2650,7 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname, int ret; if (strcmp(param, "async_probe") == 0) { - if (strtobool(val, &mod->async_probe_requested)) + if (kstrtobool(val, &mod->async_probe_requested)) mod->async_probe_requested = true; return 0; }
strtobool() is the same as kstrtobool(). However, the latter is more used within the kernel. In order to remove strtobool() and slightly simplify kstrtox.h, switch to the other function name. While at it, include the corresponding header file (<linux/kstrtox.h>) Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- This patch is part of a serie that axes all usages of strtobool(). Each patch can be applied independently from the other ones. The last patch of the serie removes the definition of strtobool(). You may not be in copy of the cover letter. So, if needed, it is available at [1]. [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ --- kernel/module/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)