From patchwork Fri May 8 21:50:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Howells X-Patchwork-Id: 11537653 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0D5315E6 for ; Fri, 8 May 2020 21:50:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACBAB2173E for ; Fri, 8 May 2020 21:50:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SSxf0gco" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727926AbgEHVuz (ORCPT ); Fri, 8 May 2020 17:50:55 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41152 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727110AbgEHVuy (ORCPT ); Fri, 8 May 2020 17:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588974653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=WfmItu00sqA0T6UZ4ttYmvbh9bbKybU1lr+8KSmJvZg=; b=SSxf0gco69Ef0B3w4CpIMJIoMcdUnlS+Ultxrxw5cpDzWDMIgao1trzeHzz1T+VCEtq2/Z 4Km4EU4RUMlDb39KDlHjTfJzEa47p1GG/zE9Gt9PfhptQ7/xyxbB5mSLvRb5mHhu8BC/0i hHvxdchN2xxYUfbI1LzNDYeEleBgmDU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-335-rgvPNQIfOmSSfAHrHEesyw-1; Fri, 08 May 2020 17:50:52 -0400 X-MC-Unique: rgvPNQIfOmSSfAHrHEesyw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9D138014C1; Fri, 8 May 2020 21:50:50 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-118-225.rdu2.redhat.com [10.10.118.225]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B5CE5C3FD; Fri, 8 May 2020 21:50:43 +0000 (UTC) Subject: [PATCH 0/4] cachefiles, nfs: Fixes From: David Howells To: torvalds@linux-foundation.org, Trond Myklebust Cc: Carlos Maiolino , Dave Wysochanski , David Wysochanski , dhowells@redhat.com, Anna Schumaker , linux-nfs@vger.kernel.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 08 May 2020 22:50:42 +0100 Message-ID: <158897464246.1116213.8184341356151224705.stgit@warthog.procyon.org.uk> User-Agent: StGit/0.21 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Linus, Trond, Anna, Can you pull these fixes for cachefiles and NFS's use of fscache? Should they go through the NFS tree or directly upstream? The things fixed are: (1) The reorganisation of bmap() use accidentally caused the return value of cachefiles_read_or_alloc_pages() to get corrupted. (2) The NFS superblock index key accidentally got changed to include a number of kernel pointers - meaning that the key isn't matchable after a reboot. (3) A redundant check in nfs_fscache_get_super_cookie(). (4) The NFS change_attr sometimes set in the auxiliary data for the caching of an file and sometimes not, which causes the cache to get discarded when it shouldn't. The patches are tagged here: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git tag fscache-fixes-20200508 Thanks, David --- Dave Wysochanski (3): NFS: Fix fscache super_cookie index_key from changing after umount NFS: Fix fscache super_cookie allocation NFSv4: Fix fscache cookie aux_data to ensure change_attr is included David Howells (1): cachefiles: Fix corruption of the return value in cachefiles_read_or_alloc_pages() fs/cachefiles/rdwr.c | 10 +++++----- fs/nfs/fscache.c | 39 ++++++++++++++++++--------------------- fs/nfs/super.c | 1 - 3 files changed, 23 insertions(+), 27 deletions(-)