| Message ID | 1633645823-31235-1-git-send-email-dwysocha@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Various NFS fscache cleanups | expand |
On Thu, Oct 7, 2021 at 6:31 PM Dave Wysochanski <dwysocha@redhat.com> wrote: > > This patchset is on top of David Howells patchset he just posted as > v3 of "fscache: Replace and remove old I/O API" and is based on his > fscache-remove-old-io branch at > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-remove-old-io > NOTE: fscache-remove-old-io was previously "fscache-iter-3" but it's been > renamed to better reflect the purpose. > > The series is also at: > https://github.com/DaveWysochanskiRH/kernel.git > https://github.com/DaveWysochanskiRH/kernel/tree/fscache-remove-old-io-nfs-fixes > > Testing is looking ok so far and is still ongoing at BakeAThon and in > my local testbed with tracepoints enabled via: > trace-cmd start -e fscache:* -e nfs:* -e nfs4:* -e cachefiles:* > > Changes in v2 of this series > - Dropped first patch of v1 series (dhowells updated his patch) > - Don't rename or change the value of NFSDBG_FSCACHE (Trond) > - Rename nfs_readpage_from_fscache and nfs_readpage_to_fscache > - Rename enable/disable tracepoints to start with "nfs_fscache" > - Rename fscache IO tracepoints to better reflect the new function names > - Place the fscache IO tracepoints at begin and end of the functions > > Dave Wysochanski (7): > NFS: Use nfs_i_fscache() consistently within NFS fscache code > NFS: Cleanup usage of nfs_inode in fscache interface and handle i_size > properly > NFS: Convert NFS fscache enable/disable dfprintks to tracepoints > NFS: Rename fscache read and write pages functions > NFS: Replace dfprintks with tracepoints in read and write page > functions > NFS: Remove remaining dfprintks related to fscache cookies > NFS: Remove remaining usages of NFSDBG_FSCACHE > > fs/nfs/fscache-index.c | 2 - > fs/nfs/fscache.c | 76 +++++++++++++---------------------- > fs/nfs/fscache.h | 25 ++++++------ > fs/nfs/nfstrace.h | 98 +++++++++++++++++++++++++++++++++++++++++++++ > fs/nfs/read.c | 4 +- > include/uapi/linux/nfs_fs.h | 2 +- > 6 files changed, 140 insertions(+), 67 deletions(-) > > -- > 1.8.3.1 > Just a report on the testing of this patchset, which also tested dhowells fscache-remove-old-io branch. Overall this looks very stable. I ran some custom unit tests as well as many xfstest runs. I saw no oops or other significant problems during any of the runs. I saw no differences in Failures on xfstest runs between 5.15.0-rc4 and this set. I ran the following configurations of servers and NFS options for the runs (5.15.0-rc4, then 5.15.0-rc4 + this patchset). 1. hammerspace (pnfs flexfiles): vers=4.1,fsc; vers=4.1,nofsc; vers=4.2,fsc; vers=4.2,nofsc 2. ontap9.x (pnfs filelayout): vers=4.1,fsc; vers=4.1,nofsc 3. rhel7u8 (3.10.0-1127.8.2.el7): vers=3,nofsc; vers=4.0,nofsc; vers=4.0,fsc; vers=4.2,fsc; vers=4.2,nofsc 4. rhel8 (4.18.0-193.28.1.el8): vers=4.2,fsc
This patchset is on top of David Howells patchset he just posted as v3 of "fscache: Replace and remove old I/O API" and is based on his fscache-remove-old-io branch at https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-remove-old-io NOTE: fscache-remove-old-io was previously "fscache-iter-3" but it's been renamed to better reflect the purpose. The series is also at: https://github.com/DaveWysochanskiRH/kernel.git https://github.com/DaveWysochanskiRH/kernel/tree/fscache-remove-old-io-nfs-fixes Testing is looking ok so far and is still ongoing at BakeAThon and in my local testbed with tracepoints enabled via: trace-cmd start -e fscache:* -e nfs:* -e nfs4:* -e cachefiles:* Changes in v2 of this series - Dropped first patch of v1 series (dhowells updated his patch) - Don't rename or change the value of NFSDBG_FSCACHE (Trond) - Rename nfs_readpage_from_fscache and nfs_readpage_to_fscache - Rename enable/disable tracepoints to start with "nfs_fscache" - Rename fscache IO tracepoints to better reflect the new function names - Place the fscache IO tracepoints at begin and end of the functions Dave Wysochanski (7): NFS: Use nfs_i_fscache() consistently within NFS fscache code NFS: Cleanup usage of nfs_inode in fscache interface and handle i_size properly NFS: Convert NFS fscache enable/disable dfprintks to tracepoints NFS: Rename fscache read and write pages functions NFS: Replace dfprintks with tracepoints in read and write page functions NFS: Remove remaining dfprintks related to fscache cookies NFS: Remove remaining usages of NFSDBG_FSCACHE fs/nfs/fscache-index.c | 2 - fs/nfs/fscache.c | 76 +++++++++++++---------------------- fs/nfs/fscache.h | 25 ++++++------ fs/nfs/nfstrace.h | 98 +++++++++++++++++++++++++++++++++++++++++++++ fs/nfs/read.c | 4 +- include/uapi/linux/nfs_fs.h | 2 +- 6 files changed, 140 insertions(+), 67 deletions(-)