[v2,0/8] Clean up struct svc_serv_ops

Message

Chuck Lever Feb. 17, 2022, 4:05 p.m. UTC

Here is the completed series of patches to remove struct
svc_serv_ops, as suggested by Neil Brown. The original material was
introduced several years ago when we planned to convert the RPC
server to use work queues. That work was never completed.

Removal now is to eliminate some unnecessary virtual functions
and to pave the way for the possibility of dynamic nfsd thread
management.

The full set of patches has been provisionally applied to my
for-next branch to enable broad testing. Comments welcome.

---

Chuck Lever (8):
      SUNRPC: Remove the .svo_enqueue_xprt method
      SUNRPC: Merge svc_do_enqueue_xprt() into svc_enqueue_xprt()
      SUNRPC: Remove svo_shutdown method
      SUNRPC: Rename svc_create_xprt()
      SUNRPC: Rename svc_close_xprt()
      SUNRPC: Remove svc_shutdown_net()
      NFSD: Remove svc_serv_ops::svo_module
      NFSD: Move svc_serv_ops::svo_function into struct svc_serv


 fs/lockd/svc.c                             | 24 +++-----
 fs/nfs/callback.c                          | 66 +++++++--------------
 fs/nfs/nfs4state.c                         |  1 -
 fs/nfsd/nfsctl.c                           | 10 ++--
 fs/nfsd/nfssvc.c                           | 23 +++-----
 include/linux/sunrpc/svc.h                 | 26 ++-------
 include/linux/sunrpc/svc_xprt.h            | 11 ++--
 kernel/module.c                            |  2 +-
 net/sunrpc/svc.c                           | 50 ++++++++--------
 net/sunrpc/svc_xprt.c                      | 68 ++++++++++++++--------
 net/sunrpc/xprtrdma/svc_rdma_backchannel.c |  2 +-
 11 files changed, 122 insertions(+), 161 deletions(-)

--
Chuck Lever

Comments

NeilBrown Feb. 17, 2022, 10:36 p.m. UTC | #1

On Fri, 18 Feb 2022, Chuck Lever wrote:
> Here is the completed series of patches to remove struct
> svc_serv_ops, as suggested by Neil Brown. The original material was
> introduced several years ago when we planned to convert the RPC
> server to use work queues. That work was never completed.
> 
> Removal now is to eliminate some unnecessary virtual functions
> and to pave the way for the possibility of dynamic nfsd thread
> management.
> 
> The full set of patches has been provisionally applied to my
> for-next branch to enable broad testing. Comments welcome.

All looks good - lots of nice cleanups there.

Thanks,
NeilBrown