mbox series

[0/2] Minor improvements for fsidd in nfs-utils

Message ID 168352657591.17279.393573102599959056.stgit@noble.brown (mailing list archive)
Headers show
Series Minor improvements for fsidd in nfs-utils | expand

Message

NeilBrown May 8, 2023, 6:19 a.m. UTC
nfs-utils in openSUSE was recently updated to a version with fsidd and a
routine security audit was performed.  No real security issues were
found but a couple of oddities were highlighted.  The follow two patches
propose ways to clean up these oddities.

NeilBrown


---

NeilBrown (2):
      fsidd: don't use assert() on expr with side-effect.
      fsidd: provide better default socket name.


 support/reexport/fsidd.c    | 38 +++++++++++++++++++++----------------
 support/reexport/reexport.c |  3 +++
 support/reexport/reexport.h |  2 +-
 3 files changed, 26 insertions(+), 17 deletions(-)

--
Signature

Comments

Richard Weinberger May 8, 2023, 7:17 a.m. UTC | #1
Niel,

----- Ursprüngliche Mail -----
> Von: "NeilBrown" <neilb@suse.de>
> nfs-utils in openSUSE was recently updated to a version with fsidd and a
> routine security audit was performed.  No real security issues were
> found but a couple of oddities were highlighted.  The follow two patches
> propose ways to clean up these oddities.

Nice! TBH, the series got faster merged than expected. ;-)

Acked-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard
Steve Dickson May 11, 2023, 7:39 p.m. UTC | #2
On 5/8/23 2:19 AM, NeilBrown wrote:
> nfs-utils in openSUSE was recently updated to a version with fsidd and a
> routine security audit was performed.  No real security issues were
> found but a couple of oddities were highlighted.  The follow two patches
> propose ways to clean up these oddities.
> 
> NeilBrown
> 
> 
> ---
> 
> NeilBrown (2):
>        fsidd: don't use assert() on expr with side-effect.
>        fsidd: provide better default socket name.
> 
> 
>   support/reexport/fsidd.c    | 38 +++++++++++++++++++++----------------
>   support/reexport/reexport.c |  3 +++
>   support/reexport/reexport.h |  2 +-
>   3 files changed, 26 insertions(+), 17 deletions(-)
> 
> --
> Signature
> 
Committed... (tag: nfs-utils-2-6-4-rc1)

steved