From patchwork Mon May 8 06:19:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: NeilBrown X-Patchwork-Id: 13234096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E38DC77B7F for ; Mon, 8 May 2023 06:20:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232161AbjEHGUV (ORCPT ); Mon, 8 May 2023 02:20:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232546AbjEHGUU (ORCPT ); Mon, 8 May 2023 02:20:20 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 471BA1FEA for ; Sun, 7 May 2023 23:20:19 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D80371FD9F; Mon, 8 May 2023 06:20:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683526817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ve1c6/jYtA0PHTK5NzLGxLdTU53SFWk5zk+igbF0mic=; b=SIZpo5jUA2/V6xwbht0g2ca3BVLV9aDS/oATfX14spICoBTrs66V5lO0L1bBkK5VSy5soD 8oIOStgBDziGa2K7cXfm5hQJ/MaZEQ7C+xpYevo5A0MUVBMfZeAfJgbAj3Qai63WM55dGI 0o4BvhG0BQ8RbjpAxxUjnuCVaQk6Z5w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683526817; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Ve1c6/jYtA0PHTK5NzLGxLdTU53SFWk5zk+igbF0mic=; b=2NBtVLUqIJA8tmHxE0YkXTZg2iQSvhy+be4CFrCT9qrFVcu6H4s+/lZ3Sll7tPXLtrtm6C ayrjvsAiIT3LK+AQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A054F13499; Mon, 8 May 2023 06:20:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id D0wzFaCUWGRMGAAAMHmgww (envelope-from ); Mon, 08 May 2023 06:20:16 +0000 Subject: [PATCH 0/2] Minor improvements for fsidd in nfs-utils From: NeilBrown To: Steve Dickson , Richard Weinberger Cc: linux-nfs@vger.kernel.org Date: Mon, 08 May 2023 16:19:11 +1000 Message-ID: <168352657591.17279.393573102599959056.stgit@noble.brown> User-Agent: StGit/1.5 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org nfs-utils in openSUSE was recently updated to a version with fsidd and a routine security audit was performed. No real security issues were found but a couple of oddities were highlighted. The follow two patches propose ways to clean up these oddities. NeilBrown Acked-by: Richard Weinberger --- NeilBrown (2): fsidd: don't use assert() on expr with side-effect. fsidd: provide better default socket name. support/reexport/fsidd.c | 38 +++++++++++++++++++++---------------- support/reexport/reexport.c | 3 +++ support/reexport/reexport.h | 2 +- 3 files changed, 26 insertions(+), 17 deletions(-) -- Signature