mbox series

[v1,0/7] Several minor NFSD clean-ups

Message ID 168657912781.5674.12501431304770900992.stgit@manet.1015granger.net (mailing list archive)
Headers show
Series Several minor NFSD clean-ups | expand

Message

Chuck Lever June 12, 2023, 2:13 p.m. UTC
These are not strongly related to each other, but there was a whole
collection such that I didn't feel like posting each individually.

---

Chuck Lever (7):
      SUNRPC: Move initialization of rq_stime
      NFSD: Add an nfsd4_encode_nfstime4() helper
      svcrdma: Convert "might sleep" comment into a code annotation
      svcrdma: trace cc_release calls
      svcrdma: Remove an unused argument from __svc_rdma_put_rw_ctxt()
      SUNRPC: Fix comments for transport class registration
      SUNRPC: Remove transport class dprintk call sites


 fs/nfsd/nfs4xdr.c                     | 46 +++++++++++++++------------
 include/trace/events/rpcrdma.h        |  8 +++++
 net/sunrpc/svc_xprt.c                 | 18 ++++++++---
 net/sunrpc/xprtrdma/svc_rdma_rw.c     | 14 ++++----
 net/sunrpc/xprtrdma/svc_rdma_sendto.c |  2 ++
 5 files changed, 58 insertions(+), 30 deletions(-)

--
Chuck Lever

Comments

Jeff Layton June 12, 2023, 2:27 p.m. UTC | #1
On Mon, 2023-06-12 at 10:13 -0400, Chuck Lever wrote:
> These are not strongly related to each other, but there was a whole
> collection such that I didn't feel like posting each individually.
> 
> ---
> 
> Chuck Lever (7):
>       SUNRPC: Move initialization of rq_stime
>       NFSD: Add an nfsd4_encode_nfstime4() helper
>       svcrdma: Convert "might sleep" comment into a code annotation
>       svcrdma: trace cc_release calls
>       svcrdma: Remove an unused argument from __svc_rdma_put_rw_ctxt()
>       SUNRPC: Fix comments for transport class registration
>       SUNRPC: Remove transport class dprintk call sites
> 
> 
>  fs/nfsd/nfs4xdr.c                     | 46 +++++++++++++++------------
>  include/trace/events/rpcrdma.h        |  8 +++++
>  net/sunrpc/svc_xprt.c                 | 18 ++++++++---
>  net/sunrpc/xprtrdma/svc_rdma_rw.c     | 14 ++++----
>  net/sunrpc/xprtrdma/svc_rdma_sendto.c |  2 ++
>  5 files changed, 58 insertions(+), 30 deletions(-)
> 
> --
> Chuck Lever
> 

This all looks good to me:

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Tom Talpey June 13, 2023, 1:29 p.m. UTC | #2
On 6/12/2023 10:27 AM, Jeff Layton wrote:
> On Mon, 2023-06-12 at 10:13 -0400, Chuck Lever wrote:
>> These are not strongly related to each other, but there was a whole
>> collection such that I didn't feel like posting each individually.
>>
>> ---
>>
>> Chuck Lever (7):
>>        SUNRPC: Move initialization of rq_stime
>>        NFSD: Add an nfsd4_encode_nfstime4() helper
>>        svcrdma: Convert "might sleep" comment into a code annotation
>>        svcrdma: trace cc_release calls
>>        svcrdma: Remove an unused argument from __svc_rdma_put_rw_ctxt()
>>        SUNRPC: Fix comments for transport class registration
>>        SUNRPC: Remove transport class dprintk call sites
>>
>>
>>   fs/nfsd/nfs4xdr.c                     | 46 +++++++++++++++------------
>>   include/trace/events/rpcrdma.h        |  8 +++++
>>   net/sunrpc/svc_xprt.c                 | 18 ++++++++---
>>   net/sunrpc/xprtrdma/svc_rdma_rw.c     | 14 ++++----
>>   net/sunrpc/xprtrdma/svc_rdma_sendto.c |  2 ++
>>   5 files changed, 58 insertions(+), 30 deletions(-)
>>
>> --
>> Chuck Lever
>>
> 
> This all looks good to me:
> 
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> 

Ditto.

Acked-by: Tom Talpey <tom@talpey.com>
Chuck Lever June 13, 2023, 2:01 p.m. UTC | #3
> On Jun 13, 2023, at 9:29 AM, Tom Talpey <tom@talpey.com> wrote:
> 
> On 6/12/2023 10:27 AM, Jeff Layton wrote:
>> On Mon, 2023-06-12 at 10:13 -0400, Chuck Lever wrote:
>>> These are not strongly related to each other, but there was a whole
>>> collection such that I didn't feel like posting each individually.
>>> 
>>> ---
>>> 
>>> Chuck Lever (7):
>>>       SUNRPC: Move initialization of rq_stime
>>>       NFSD: Add an nfsd4_encode_nfstime4() helper
>>>       svcrdma: Convert "might sleep" comment into a code annotation
>>>       svcrdma: trace cc_release calls
>>>       svcrdma: Remove an unused argument from __svc_rdma_put_rw_ctxt()
>>>       SUNRPC: Fix comments for transport class registration
>>>       SUNRPC: Remove transport class dprintk call sites
>>> 
>>> 
>>>  fs/nfsd/nfs4xdr.c                     | 46 +++++++++++++++------------
>>>  include/trace/events/rpcrdma.h        |  8 +++++
>>>  net/sunrpc/svc_xprt.c                 | 18 ++++++++---
>>>  net/sunrpc/xprtrdma/svc_rdma_rw.c     | 14 ++++----
>>>  net/sunrpc/xprtrdma/svc_rdma_sendto.c |  2 ++
>>>  5 files changed, 58 insertions(+), 30 deletions(-)
>>> 
>>> --
>>> Chuck Lever
>>> 
>> This all looks good to me:
>> Reviewed-by: Jeff Layton <jlayton@kernel.org>
> 
> Ditto.
> 
> Acked-by: Tom Talpey <tom@talpey.com>

Thanks, applied and pushed.

--
Chuck Lever