mbox series

[v2,0/2] NFSD: use CB_GETATTR to handle GETATTR conflict with write delegation

Message ID 1694648301-26746-1-git-send-email-dai.ngo@oracle.com (mailing list archive)
Headers show
Series NFSD: use CB_GETATTR to handle GETATTR conflict with write delegation | expand

Message

Dai Ngo Sept. 13, 2023, 11:38 p.m. UTC
Currently GETATTR conflict with a write delegation is handled by
recalling the delegation before replying to the GETATTR.

This patch series add supports for CB_GETATTR callback to get the latest
change_info and size information of the file from the client that holds
the delegation to reply to the GETATTR from the second client.

v2:
  . fix kernel test robot report of missing function parameter description
    of nfsd4_deleg_getattr_conflict()

Comments

Chuck Lever Sept. 15, 2023, 3:57 p.m. UTC | #1
On Wed, Sep 13, 2023 at 04:38:19PM -0700, Dai Ngo wrote:
> Currently GETATTR conflict with a write delegation is handled by
> recalling the delegation before replying to the GETATTR.
> 
> This patch series add supports for CB_GETATTR callback to get the latest
> change_info and size information of the file from the client that holds
> the delegation to reply to the GETATTR from the second client.
> 
> v2:
>   . fix kernel test robot report of missing function parameter description
>     of nfsd4_deleg_getattr_conflict()

This series has been applied to nfsd-next for broader testing.
Thank you, Dai!
Jeff Layton Sept. 18, 2023, 3:42 p.m. UTC | #2
On Wed, 2023-09-13 at 16:38 -0700, Dai Ngo wrote:
> Currently GETATTR conflict with a write delegation is handled by
> recalling the delegation before replying to the GETATTR.
> 
> This patch series add supports for CB_GETATTR callback to get the latest
> change_info and size information of the file from the client that holds
> the delegation to reply to the GETATTR from the second client.
> 
> v2:
>   . fix kernel test robot report of missing function parameter description
>     of nfsd4_deleg_getattr_conflict()
> 

This all looks good to me. Nice work, Dai!

Reviewed-by: Jeff Layton <jlayton@kernel.org>