[v1,0/8] Clean up XDR encoders for pNFS operations

Message

Chuck Lever Sept. 25, 2023, 1:27 p.m. UTC

Tidy up the server-side XDR encoders for pNFS-related operations.
Note that this does not touch the layout driver code; that can be
done later.

Series applies to nfsd-next. See topic branch
"nfsd4-encoder-overhaul" in this repo:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

---

Chuck Lever (8):
      NFSD: Add nfsd4_encode_count4()
      NFSD: Clean up nfsd4_encode_stateid()
      NFSD: Make @lgp parameter of ->encode_layoutget a const pointer
      NFSD: Clean up nfsd4_encode_layoutget()
      NFSD: Clean up nfsd4_encode_layoutcommit()
      NFSD: Clean up nfsd4_encode_layoutreturn()
      NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointer
      NFSD: Clean up nfsd4_encode_getdeviceinfo()


 fs/nfsd/blocklayoutxdr.c    |   6 +-
 fs/nfsd/blocklayoutxdr.h    |   4 +-
 fs/nfsd/flexfilelayoutxdr.c |   6 +-
 fs/nfsd/flexfilelayoutxdr.h |   4 +-
 fs/nfsd/nfs4layouts.c       |   6 +-
 fs/nfsd/nfs4proc.c          |   4 +-
 fs/nfsd/nfs4xdr.c           | 206 ++++++++++++++++++++----------------
 fs/nfsd/pnfs.h              |   6 +-
 fs/nfsd/xdr4.h              |   7 +-
 9 files changed, 135 insertions(+), 114 deletions(-)

--
Chuck Lever

Comments

Jeff Layton Sept. 29, 2023, 4:34 p.m. UTC | #1

On Mon, 2023-09-25 at 09:27 -0400, Chuck Lever wrote:
> Tidy up the server-side XDR encoders for pNFS-related operations.
> Note that this does not touch the layout driver code; that can be
> done later.
> 
> Series applies to nfsd-next. See topic branch
> "nfsd4-encoder-overhaul" in this repo:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
> 
> ---
> 
> Chuck Lever (8):
>       NFSD: Add nfsd4_encode_count4()
>       NFSD: Clean up nfsd4_encode_stateid()
>       NFSD: Make @lgp parameter of ->encode_layoutget a const pointer
>       NFSD: Clean up nfsd4_encode_layoutget()
>       NFSD: Clean up nfsd4_encode_layoutcommit()
>       NFSD: Clean up nfsd4_encode_layoutreturn()
>       NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointer
>       NFSD: Clean up nfsd4_encode_getdeviceinfo()
> 
> 
>  fs/nfsd/blocklayoutxdr.c    |   6 +-
>  fs/nfsd/blocklayoutxdr.h    |   4 +-
>  fs/nfsd/flexfilelayoutxdr.c |   6 +-
>  fs/nfsd/flexfilelayoutxdr.h |   4 +-
>  fs/nfsd/nfs4layouts.c       |   6 +-
>  fs/nfsd/nfs4proc.c          |   4 +-
>  fs/nfsd/nfs4xdr.c           | 206 ++++++++++++++++++++----------------
>  fs/nfsd/pnfs.h              |   6 +-
>  fs/nfsd/xdr4.h              |   7 +-
>  9 files changed, 135 insertions(+), 114 deletions(-)
> 
> --
> Chuck Lever
> 

Looks good. Nice cleanup.

Reviewed-by: Jeff Layton <[e-mail]>