mbox series

[RFC,0/5] Possible changes to nfs-utils junction support

Message ID 170050610386.123525.8429348635736141592.stgit@manet.1015granger.net (mailing list archive)
Headers show
Series Possible changes to nfs-utils junction support | expand

Message

Chuck Lever Nov. 20, 2023, 6:53 p.m. UTC
Bruce suggested, years ago, that the nfsref command should become
the premier administrative interface for managing NFSD's referral
behavior.

Towards that end, some clean-up is needed for the nfsref command in
nfs-utils, which is presented for review here.

I'm hesitant to introduce more documentation at this time for the
refer= and replica= export options if we plan to remove them in the
medium term.

---

Chuck Lever (5):
      junction: Replace xmlParseMemory
      junction: Remove xmlIndentTreeOutput
      nfsref: Remove unneeded #include in utils/nfsref/nfsref.c
      nfsref: Improve nfsref(5)
      configure: Make --enable-junction=yes the default


 configure.ac            |  6 ++---
 support/junction/xml.c  |  3 +--
 utils/nfsref/nfsref.c   |  2 --
 utils/nfsref/nfsref.man | 60 +++++++++++++++++++++--------------------
 4 files changed, 35 insertions(+), 36 deletions(-)

--
Chuck Lever

Comments

Chuck Lever Nov. 20, 2023, 6:58 p.m. UTC | #1
> On Nov 20, 2023, at 1:53 PM, Chuck Lever <cel@kernel.org> wrote:
> 
> Bruce suggested, years ago, that the nfsref command should become
> the premier administrative interface for managing NFSD's referral
> behavior.
> 
> Towards that end, some clean-up is needed for the nfsref command in
> nfs-utils, which is presented for review here.

I forgot to mention: the series is marked RFC because they are
compile-tested only.


> I'm hesitant to introduce more documentation at this time for the
> refer= and replica= export options if we plan to remove them in the
> medium term.
> 
> ---
> 
> Chuck Lever (5):
>      junction: Replace xmlParseMemory
>      junction: Remove xmlIndentTreeOutput
>      nfsref: Remove unneeded #include in utils/nfsref/nfsref.c
>      nfsref: Improve nfsref(5)
>      configure: Make --enable-junction=yes the default
> 
> 
> configure.ac            |  6 ++---
> support/junction/xml.c  |  3 +--
> utils/nfsref/nfsref.c   |  2 --
> utils/nfsref/nfsref.man | 60 +++++++++++++++++++++--------------------
> 4 files changed, 35 insertions(+), 36 deletions(-)
> 
> --
> Chuck Lever
> 

--
Chuck Lever
Chuck Lever Nov. 21, 2023, 3:48 p.m. UTC | #2
> On Nov 20, 2023, at 1:58 PM, Chuck Lever III <chuck.lever@oracle.com> wrote:
> 
> 
> 
>> On Nov 20, 2023, at 1:53 PM, Chuck Lever <cel@kernel.org> wrote:
>> 
>> Bruce suggested, years ago, that the nfsref command should become
>> the premier administrative interface for managing NFSD's referral
>> behavior.
>> 
>> Towards that end, some clean-up is needed for the nfsref command in
>> nfs-utils, which is presented for review here.
> 
> I forgot to mention: the series is marked RFC because they are
> compile-tested only.

I've done some limited testing now. These seem to work.


>> I'm hesitant to introduce more documentation at this time for the
>> refer= and replica= export options if we plan to remove them in the
>> medium term.
>> 
>> ---
>> 
>> Chuck Lever (5):
>>     junction: Replace xmlParseMemory
>>     junction: Remove xmlIndentTreeOutput
>>     nfsref: Remove unneeded #include in utils/nfsref/nfsref.c
>>     nfsref: Improve nfsref(5)
>>     configure: Make --enable-junction=yes the default
>> 
>> 
>> configure.ac            |  6 ++---
>> support/junction/xml.c  |  3 +--
>> utils/nfsref/nfsref.c   |  2 --
>> utils/nfsref/nfsref.man | 60 +++++++++++++++++++++--------------------
>> 4 files changed, 35 insertions(+), 36 deletions(-)
>> 
>> --
>> Chuck Lever
>> 
> 
> --
> Chuck Lever
> 
> 

--
Chuck Lever
Steve Dickson Dec. 7, 2023, 7:36 p.m. UTC | #3
On 11/20/23 1:53 PM, Chuck Lever wrote:
> Bruce suggested, years ago, that the nfsref command should become
> the premier administrative interface for managing NFSD's referral
> behavior.
> 
> Towards that end, some clean-up is needed for the nfsref command in
> nfs-utils, which is presented for review here.
> 
> I'm hesitant to introduce more documentation at this time for the
> refer= and replica= export options if we plan to remove them in the
> medium term.
> 
> ---
> 
> Chuck Lever (5):
>        junction: Replace xmlParseMemory
>        junction: Remove xmlIndentTreeOutput
>        nfsref: Remove unneeded #include in utils/nfsref/nfsref.c
>        nfsref: Improve nfsref(5)
>        configure: Make --enable-junction=yes the default
> 
> 
>   configure.ac            |  6 ++---
>   support/junction/xml.c  |  3 +--
>   utils/nfsref/nfsref.c   |  2 --
>   utils/nfsref/nfsref.man | 60 +++++++++++++++++++++--------------------
>   4 files changed, 35 insertions(+), 36 deletions(-)
> 
> --
> Chuck Lever
> 
Committed... (tag: nfs-utils-2-7-1-rc2)

steved.