mbox series

[v2,0/3] don't collapse transports for the trunkable

Message ID 20210609215319.5518-1-olga.kornievskaia@gmail.com (mailing list archive)
Headers show
Series don't collapse transports for the trunkable | expand

Message

Olga Kornievskaia June 9, 2021, 9:53 p.m. UTC
From: Olga Kornievskaia <kolga@netapp.com>

This patch series attempts to allow for new mounts that are to the
same server (ie nfsv4.1+ session trunkable servers) but different
network addresses to use connections associated with those mounts
but still use the same client structure.

A new mount options, "max_connect", controls how many extra transports
can be added to an existing client, with maximum of 128 transports in
total for either nconnect transports (which are multiple connections
but to the same IP) or transports that are going to different network
addresses.

Olga Kornievskaia (3):
  SUNRPC query xprt switch for number of active transports
  NFSv4 introduce max_connect mount options
  NFSv4.1+ add trunking when server trunking detected

 fs/nfs/client.c             |  1 +
 fs/nfs/fs_context.c         |  8 +++++++
 fs/nfs/internal.h           |  2 ++
 fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
 fs/nfs/super.c              |  2 ++
 include/linux/nfs_fs_sb.h   |  1 +
 include/linux/sunrpc/clnt.h |  2 ++
 net/sunrpc/clnt.c           | 13 +++++++++++
 8 files changed, 70 insertions(+), 2 deletions(-)

Comments

Olga Kornievskaia June 9, 2021, 10:27 p.m. UTC | #1
Apologizes, the title got corrupted. The title of the series should be
something like : "don't collapse trunkable transports"

On Wed, Jun 9, 2021 at 5:53 PM Olga Kornievskaia
<olga.kornievskaia@gmail.com> wrote:
>
> From: Olga Kornievskaia <kolga@netapp.com>
>
> This patch series attempts to allow for new mounts that are to the
> same server (ie nfsv4.1+ session trunkable servers) but different
> network addresses to use connections associated with those mounts
> but still use the same client structure.
>
> A new mount options, "max_connect", controls how many extra transports
> can be added to an existing client, with maximum of 128 transports in
> total for either nconnect transports (which are multiple connections
> but to the same IP) or transports that are going to different network
> addresses.
>
> Olga Kornievskaia (3):
>   SUNRPC query xprt switch for number of active transports
>   NFSv4 introduce max_connect mount options
>   NFSv4.1+ add trunking when server trunking detected
>
>  fs/nfs/client.c             |  1 +
>  fs/nfs/fs_context.c         |  8 +++++++
>  fs/nfs/internal.h           |  2 ++
>  fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
>  fs/nfs/super.c              |  2 ++
>  include/linux/nfs_fs_sb.h   |  1 +
>  include/linux/sunrpc/clnt.h |  2 ++
>  net/sunrpc/clnt.c           | 13 +++++++++++
>  8 files changed, 70 insertions(+), 2 deletions(-)
>
> --
> 2.27.0
>
Steve Dickson June 10, 2021, 1:32 p.m. UTC | #2
Hey!

On 6/9/21 5:53 PM, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> This patch series attempts to allow for new mounts that are to the
> same server (ie nfsv4.1+ session trunkable servers) but different
> network addresses to use connections associated with those mounts
> but still use the same client structure.
> 
> A new mount options, "max_connect", controls how many extra transports
> can be added to an existing client, with maximum of 128 transports in
> total for either nconnect transports (which are multiple connections
> but to the same IP) or transports that are going to different network
> addresses.
I'm trying to figure out why this new mount option is needed...
What is it protecting? What am I missing?

Plus it needs to be documented....

steved.
> 
> Olga Kornievskaia (3):
>    SUNRPC query xprt switch for number of active transports
>    NFSv4 introduce max_connect mount options
>    NFSv4.1+ add trunking when server trunking detected
> 
>   fs/nfs/client.c             |  1 +
>   fs/nfs/fs_context.c         |  8 +++++++
>   fs/nfs/internal.h           |  2 ++
>   fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
>   fs/nfs/super.c              |  2 ++
>   include/linux/nfs_fs_sb.h   |  1 +
>   include/linux/sunrpc/clnt.h |  2 ++
>   net/sunrpc/clnt.c           | 13 +++++++++++
>   8 files changed, 70 insertions(+), 2 deletions(-)
>
Olga Kornievskaia June 10, 2021, 5:33 p.m. UTC | #3
On Thu, Jun 10, 2021 at 9:29 AM Steve Dickson <steved@redhat.com> wrote:
>
> Hey!
>
> On 6/9/21 5:53 PM, Olga Kornievskaia wrote:
> > From: Olga Kornievskaia <kolga@netapp.com>
> >
> > This patch series attempts to allow for new mounts that are to the
> > same server (ie nfsv4.1+ session trunkable servers) but different
> > network addresses to use connections associated with those mounts
> > but still use the same client structure.
> >
> > A new mount options, "max_connect", controls how many extra transports
> > can be added to an existing client, with maximum of 128 transports in
> > total for either nconnect transports (which are multiple connections
> > but to the same IP) or transports that are going to different network
> > addresses.
> I'm trying to figure out why this new mount option is needed...
> What is it protecting? What am I missing?

Hopefully comments on patch3 of this series can help you answer that.

> Plus it needs to be documented....

Indeed a man page patch is needed but I was waiting to get a more
commonly accepted version of the code before adding the man page
patch.

> steved.
> >
> > Olga Kornievskaia (3):
> >    SUNRPC query xprt switch for number of active transports
> >    NFSv4 introduce max_connect mount options
> >    NFSv4.1+ add trunking when server trunking detected
> >
> >   fs/nfs/client.c             |  1 +
> >   fs/nfs/fs_context.c         |  8 +++++++
> >   fs/nfs/internal.h           |  2 ++
> >   fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
> >   fs/nfs/super.c              |  2 ++
> >   include/linux/nfs_fs_sb.h   |  1 +
> >   include/linux/sunrpc/clnt.h |  2 ++
> >   net/sunrpc/clnt.c           | 13 +++++++++++
> >   8 files changed, 70 insertions(+), 2 deletions(-)
> >
>
Olga Kornievskaia June 10, 2021, 5:39 p.m. UTC | #4
On Thu, Jun 10, 2021 at 1:33 PM Olga Kornievskaia
<olga.kornievskaia@gmail.com> wrote:
>
> On Thu, Jun 10, 2021 at 9:29 AM Steve Dickson <steved@redhat.com> wrote:
> >
> > Hey!
> >
> > On 6/9/21 5:53 PM, Olga Kornievskaia wrote:
> > > From: Olga Kornievskaia <kolga@netapp.com>
> > >
> > > This patch series attempts to allow for new mounts that are to the
> > > same server (ie nfsv4.1+ session trunkable servers) but different
> > > network addresses to use connections associated with those mounts
> > > but still use the same client structure.
> > >
> > > A new mount options, "max_connect", controls how many extra transports
> > > can be added to an existing client, with maximum of 128 transports in
> > > total for either nconnect transports (which are multiple connections
> > > but to the same IP) or transports that are going to different network
> > > addresses.
> > I'm trying to figure out why this new mount option is needed...
> > What is it protecting? What am I missing?
>
> Hopefully comments on patch3 of this series can help you answer that.

I mean patch2. But to answer briefly. It protects not creating too
many transports.

>
> > Plus it needs to be documented....
>
> Indeed a man page patch is needed but I was waiting to get a more
> commonly accepted version of the code before adding the man page
> patch.
>
> > steved.
> > >
> > > Olga Kornievskaia (3):
> > >    SUNRPC query xprt switch for number of active transports
> > >    NFSv4 introduce max_connect mount options
> > >    NFSv4.1+ add trunking when server trunking detected
> > >
> > >   fs/nfs/client.c             |  1 +
> > >   fs/nfs/fs_context.c         |  8 +++++++
> > >   fs/nfs/internal.h           |  2 ++
> > >   fs/nfs/nfs4client.c         | 43 +++++++++++++++++++++++++++++++++++--
> > >   fs/nfs/super.c              |  2 ++
> > >   include/linux/nfs_fs_sb.h   |  1 +
> > >   include/linux/sunrpc/clnt.h |  2 ++
> > >   net/sunrpc/clnt.c           | 13 +++++++++++
> > >   8 files changed, 70 insertions(+), 2 deletions(-)
> > >
> >